fix: correct response body for 'GET /orders' (jordan-dimov#19)

Author: daconjurer

ctenex/api/v1/controllers/exchange.py

@@ -10,7 +10,11 @@
 from ctenex.domain.order_book.contract.reader import contracts_reader
 from ctenex.domain.order_book.contract.schemas import ContractGetResponse
 from ctenex.domain.order_book.order.model import Order
-from ctenex.domain.order_book.order.schemas import OrderAddRequest, OrderAddResponse
+from ctenex.domain.order_book.order.schemas import (
+    OrderAddRequest,
+    OrderAddResponse,
+    OrderGetResponse,
+)
 
 router = APIRouter(tags=["exchange"])
 
@@ -30,11 +34,11 @@ async def place_order(
 
 
 @router.get("/orders")
-async def get_order(
+async def get_orders(
     contract_id: ContractCode,
-) -> list[Order]:
+) -> list[OrderGetResponse]:
     orders: list[Order] = await matching_engine.get_orders(contract_id)
-    return orders
+    return [OrderGetResponse(**order.model_dump(exclude_none=True)) for order in orders]
 
 
 @router.get("/supported-contracts")

ctenex/domain/order_book/order/schemas.py

@@ -1,3 +1,4 @@
+from datetime import datetime
 from decimal import Decimal
 from uuid import UUID
 
@@ -24,3 +25,16 @@ class OrderAddResponse(BaseModel):
     price: Decimal | None = None
     quantity: Decimal
     status: OrderStatus
+
+
+class OrderGetResponse(BaseModel):
+    id: UUID
+    contract_id: str
+    trader_id: UUID
+    side: OrderSide
+    type: OrderType
+    price: Decimal | None = None
+    quantity: Decimal
+    status: OrderStatus
+    remaining_quantity: Decimal | None = None
+    placed_at: datetime