Skip to content

Commit 776f9e5

Browse files
committed
Minor todo comment
1 parent 659e53a commit 776f9e5

1 file changed

Lines changed: 1 addition & 0 deletions

File tree

src/metabase/driver/athena.clj

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -245,6 +245,7 @@
245245

246246
;; Required because we're calling our own custom private get-tables method to support Athena
247247
(defn- fast-active-tables [driver, ^DatabaseMetaData metadata, & [db-name-or-nil]]
248+
;; TODO: Catch errors here so a single exception doesn't fail the entire schema
248249
(with-open [rs (.getSchemas metadata)]
249250
(let [all-schemas (set (map :table_schem (jdbc/metadata-result rs)))
250251
schemas (set/difference all-schemas (sql-jdbc.sync/excluded-schemas driver))]

0 commit comments

Comments
 (0)