Merge pull request #1 from dacort/fix/big-files

[fix] Better uploading

Author: dacort

src/pyssm_client/cli/coordinator.py

@@ -7,16 +7,11 @@
 import sys
 import termios
 import tty
-from typing import Any, Callable, Optional
+from typing import Any
 
 from ..communicator.data_channel import SessionDataChannel
 from ..communicator.utils import create_websocket_config
 from ..constants import CLIENT_VERSION
-from ..file_transfer.client import FileTransferClient
-from ..file_transfer.types import (
-    ChecksumType,
-    FileTransferOptions,
-)
 from ..session.plugins import StandardStreamPlugin
 from ..session.session_handler import SessionHandler
 from ..session.types import ClientConfig, SessionConfig, SessionType
@@ -479,132 +474,3 @@ async def _stop_resize_heartbeat(self) -> None:
             except asyncio.CancelledError:
                 pass
         self._resize_task = None
-
-    async def upload_file(
-        self,
-        local_path: str,
-        remote_path: str,
-        target: str,
-        progress_callback: Optional[Callable[[int, int], None]] = None,
-        verify_checksum: bool = True,
-        chunk_size: int = 65536,
-        # AWS parameters
-        profile: Optional[str] = None,
-        region: Optional[str] = None,
-        endpoint_url: Optional[str] = None,
-    ) -> bool:
-        """Upload a file to remote host via AWS SSM.
-
-        Args:
-            local_path: Path to local file
-            remote_path: Destination path on remote host
-            target: EC2 instance or managed instance ID
-            progress_callback: Optional callback for progress updates
-            verify_checksum: Whether to verify file integrity
-            chunk_size: Transfer chunk size in bytes
-            profile: AWS profile name
-            region: AWS region
-            endpoint_url: Custom AWS endpoint URL
-
-        Returns:
-            True if transfer successful, False otherwise
-        """
-        options = FileTransferOptions(
-            chunk_size=chunk_size,
-            verify_checksum=verify_checksum,
-            progress_callback=progress_callback,
-        )
-
-        client = FileTransferClient()
-        return await client.upload_file(
-            local_path=local_path,
-            remote_path=remote_path,
-            target=target,
-            options=options,
-            profile=profile,
-            region=region,
-            endpoint_url=endpoint_url,
-        )
-
-    async def download_file(
-        self,
-        remote_path: str,
-        local_path: str,
-        target: str,
-        progress_callback: Optional[Callable[[int, int], None]] = None,
-        verify_checksum: bool = True,
-        chunk_size: int = 65536,
-        # AWS parameters
-        profile: Optional[str] = None,
-        region: Optional[str] = None,
-        endpoint_url: Optional[str] = None,
-    ) -> bool:
-        """Download a file from remote host via AWS SSM.
-
-        Args:
-            remote_path: Path to remote file
-            local_path: Local destination path
-            target: EC2 instance or managed instance ID
-            progress_callback: Optional callback for progress updates
-            verify_checksum: Whether to verify file integrity
-            chunk_size: Transfer chunk size in bytes
-            profile: AWS profile name
-            region: AWS region
-            endpoint_url: Custom AWS endpoint URL
-
-        Returns:
-            True if transfer successful, False otherwise
-        """
-        options = FileTransferOptions(
-            chunk_size=chunk_size,
-            verify_checksum=verify_checksum,
-            progress_callback=progress_callback,
-        )
-
-        client = FileTransferClient()
-        return await client.download_file(
-            remote_path=remote_path,
-            local_path=local_path,
-            target=target,
-            options=options,
-            profile=profile,
-            region=region,
-            endpoint_url=endpoint_url,
-        )
-
-    async def verify_remote_file(
-        self,
-        remote_path: str,
-        target: str,
-        checksum_type: str = "md5",
-        # AWS parameters
-        profile: Optional[str] = None,
-        region: Optional[str] = None,
-        endpoint_url: Optional[str] = None,
-    ) -> Optional[str]:
-        """Get checksum of remote file.
-
-        Args:
-            remote_path: Path to remote file
-            target: EC2 instance or managed instance ID
-            checksum_type: Checksum algorithm (md5 or sha256)
-            profile: AWS profile name
-            region: AWS region
-            endpoint_url: Custom AWS endpoint URL
-
-        Returns:
-            Checksum string if successful, None otherwise
-        """
-        checksum_enum = (
-            ChecksumType.MD5 if checksum_type.lower() == "md5" else ChecksumType.SHA256
-        )
-
-        client = FileTransferClient()
-        return await client.verify_remote_file(
-            remote_path=remote_path,
-            target=target,
-            checksum_type=checksum_enum,
-            profile=profile,
-            region=region,
-            endpoint_url=endpoint_url,
-        )

src/pyssm_client/cli/main.py

@@ -207,9 +207,9 @@ def ssh(ctx: click.Context, **kwargs: Any) -> None:
 @click.option(
     "--chunk-size",
     type=int,
-    default=65536,
+    default=32768,
     show_default=True,
-    help="Transfer chunk size in bytes",
+    help="Transfer chunk size in bytes (32KB, safe for base64 encoding + protocol overhead)",
 )
 @click.option("--no-verify", is_flag=True, help="Skip checksum verification")
 @click.option(

src/pyssm_client/cli/types.py

@@ -167,7 +167,9 @@ class FileCopyArguments:
 
     # Transfer options
     encoding: FileTransferEncoding = FileTransferEncoding.BASE64
-    chunk_size: int = 65536  # 64KB
+    chunk_size: int = (
+        32768  # 32KB (safe for base64 encoding + protocol overhead within 64KB frames)
+    )
     verify_checksum: bool = True
     checksum_type: ChecksumType = ChecksumType.MD5
 

src/pyssm_client/communicator/types.py

@@ -52,6 +52,7 @@ class WebSocketConfig:
     ping_timeout: float = 10.0  # seconds
     connect_timeout: float = 30.0  # seconds
     max_message_size: int = 1024 * 1024  # 1MB
+    max_frame_size: int = 128 * 1024  # 128KB frame size limit (generous for base64)
     max_queue_size: int = 100
     retry_attempts: int = 3
     retry_delay: float = 1.0  # seconds

src/pyssm_client/communicator/websocket_channel.py

@@ -126,7 +126,7 @@ async def _attempt_connection(self) -> None:
                 connect(
                     self._config.url,
                     additional_headers=headers,
-                    max_size=self._config.max_message_size,
+                    max_size=self._config.max_frame_size,  # Use frame size limit, not message size
                     ping_interval=None,  # We handle pings manually
                     ping_timeout=None,
                 ),