Skip to content

Commit a4cc9fc

Browse files
committed
JDK-8377775: [lworld] compiler/ciReplay/TestInliningProtectionDomain.java still fails
1 parent 012ee51 commit a4cc9fc

File tree

1 file changed

+10
-7
lines changed

1 file changed

+10
-7
lines changed

test/hotspot/jtreg/compiler/ciReplay/TestInliningProtectionDomain.java

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ public void testAction() {
7070

7171
if (inlineFails) {
7272
Asserts.assertTrue(inlineesNormal.get(0).compare("compiler.ciReplay.ProtectionDomainTestNoOtherCompilationPrivate", "bar", inlineesNormal.get(0).isUnloadedSignatureClasses()));
73-
Asserts.assertTrue(inlineesReplay.get(0).compare("compiler.ciReplay.ProtectionDomainTestNoOtherCompilationPrivate", "bar", inlineesReplay.get(0).isDisallowedByReplay()));
73+
Asserts.assertTrue(inlineesReplay.get(0).compare("compiler.ciReplay.ProtectionDomainTestNoOtherCompilationPrivate", "bar", inlineesReplay.get(0).isUnloadedSignatureClasses()));
7474
} else {
7575
Asserts.assertTrue(inlineesNormal.get(4).compare("compiler.ciReplay.InliningBar", "bar2", inlineesNormal.get(4).isNormalInline()));
7676
Asserts.assertTrue(inlineesReplay.get(4).compare("compiler.ciReplay.InliningBar", "bar2", inlineesReplay.get(4).isForcedByReplay() || inlineesReplay.get(4).isForcedIncrementalInlineByReplay()));
@@ -92,9 +92,9 @@ public static void test() {
9292
bar();
9393
}
9494

95-
// Record should be resolved for the protection domain of this class because the separate compilation of bar() in
95+
// SigType should be resolved for the protection domain of this class because the separate compilation of bar() in
9696
// the normal run will resolve all classes in the signature. Inlining succeeds.
97-
private static Record bar() {
97+
private static SigType bar() {
9898
InliningFoo.foo();
9999
return null;
100100
}
@@ -111,10 +111,10 @@ public static void test() {
111111
bar(); // Not compiled before separately
112112
}
113113

114-
// Record should be resolved for the protection domain of this class because getDeclaredMethods is called in normal run
114+
// SigType should be resolved for the protection domain of this class because getDeclaredMethods is called in normal run
115115
// when validating main() method. In this process, all public methods of this class are visited and its signature classes
116116
// are resolved. Inlining of bar() succeeds.
117-
public static Record bar() {
117+
public static SigType bar() {
118118
InliningFoo.foo();
119119
return null;
120120
}
@@ -131,12 +131,12 @@ public static void test() {
131131
bar(); // Not compiled before separately
132132
}
133133

134-
// Record should be unresolved for the protection domain of this class even though getDeclaredMethods is called in normal
134+
// SigType should be unresolved for the protection domain of this class even though getDeclaredMethods is called in normal
135135
// run when validating main() method. In this process, only public methods of this class are visited and its signature
136136
// classes are resolved. Since this method is private, the signature classes are not resolved for this protection domain.
137137
// Inlining of bar() should fail in normal run with "unresolved signature classes". Therefore, replay compilation should
138138
// also not inline bar().
139-
private static Record bar() {
139+
private static SigType bar() {
140140
InliningFoo.foo();
141141
return null;
142142
}
@@ -181,3 +181,6 @@ public static void bar() {
181181

182182
private static void bar2() {}
183183
}
184+
185+
class SigType {}
186+

0 commit comments

Comments
 (0)