chore: Quick CI refactoring followups (#2099)

* Replace `skip-deep-tests-check` label with `run-deep-tests` label on PRs. Rather than skip this check and wait to see if you've fixed master, better to run them directly on the PR first.
* Updated `RELEASE.md` to indicate you need to manually trigger `deep-tests.yml` after merging the update to the version. The automation is strict and looks for a run on exactly the commit being tagged, and there isn't a way to trigger a workflow on a past commit, only the tip of a branch. It's possible to make the commit to download different from the one defining the workflow, but `check-deep-tests` would need to be refactored to understand that.

Co-authored-by: Aaron Tomb <[email protected]>

Author: robin-aws

.github/workflows/msbuild.yml

@@ -52,11 +52,14 @@ jobs:
 
   check-deep-tests:
     uses: ./.github/workflows/check-deep-tests-reusable.yml
-    if: "!(contains(github.event.pull_request.labels.*.name, 'skip-deep-tests-check'))"
+    if: "!(contains(github.event.pull_request.labels.*.name, 'run-deep-tests'))"
 
   integration-tests:
     needs: check-deep-tests
     uses: ./.github/workflows/integration-tests-reusable.yml
     with:
-      all_platforms: false
+      # By default run only on one platform, but run on all platforms if the PR has the "run-deep-tests"
+      # label, and skip checking the nightly build above.
+      # This is the best way to fix an issue in master that was only caught by the nightly build.
+      all_platforms: ${{ contains(github.event.pull_request.labels.*.name, 'run-deep-tests') }}
       num_shards: 5

RELEASE.md

@@ -22,8 +22,15 @@
    Push and cut a PR, get it approved,
    and squash and merge those changes to the `master` branch.
 
-3. Create a fresh clone of the repo locally, making sure the latest commit
-   is the squashed commit you just merged, and push the tag for this release.
+3. Kick off the deep test suite by navigating to
+   https://github.com/dafny-lang/dafny/actions/workflows/deep-tests.yml,
+   clicking the "Run workflow" dropdown, ensuring `master` is selected,
+   and clicking the "Run workflow" button. The automation for releasing
+   below will check for a run of this workflow on the exact commit
+   to release.
+
+4. Create a fresh clone of the repo locally, making sure the latest commit
+   is the squashed commit you just merged and tested, and push the tag for this release.
 
    ```
    git clone [email protected]:dafny-lang/dafny.git dafny-for-tagging
@@ -32,35 +39,35 @@
    git push v<$VER>
    ```
 
-4. A GitHub action will automatically run in reaction to the tag being pushed,
+5. A GitHub action will automatically run in reaction to the tag being pushed,
    which will build the artifacts and reference manual and then create a draft
    GitHub release. You can find and watch the progress of this workflow at
    https://github.com/dafny-lang/dafny/actions.
 
-5. Once the action completes, you should find the draft release at
+6. Once the action completes, you should find the draft release at
    https://github.com/dafny-lang/dafny/releases. Edit the release body
    to add in the release notes from `RELEASE_NOTES.md`. 
    Also check the box to create a new discussion based on
    the release, if this is not a pre-release.
 
-6. Push the "Publish" button. This will trigger yet another workflow
+7. Push the "Publish" button. This will trigger yet another workflow
    that will download the published artifacts and run a smoke test
    on multiple platforms. Again you can watch for this workflow at
    https://github.com/dafny-lang/dafny/actions.
 
-7. If preparing a pre-release, stop here, as
+8. If preparing a pre-release, stop here, as
    the following steps declare the release as the latest version, which
    is not the intention.
 
-8. If something goes wrong, delete the tag and release in GitHub, fix the
+9. If something goes wrong, delete the tag and release in GitHub, fix the
    problem and try again.
 
-9. Update the Homebrew formula for Dafny (see below).
+10. Update the Homebrew formula for Dafny (see below).
    Note that it is fine to leave this for the next day,
    and other members of the community may update the formula
    in the meantime anyway.
 
-10. Announce the new release to the world.
+11. Announce the new release to the world.
 
 ## Updating Dafny on Homebrew