|
11 | 11 | - AI favours volume over precision and ownership |
12 | 12 | - You wouldn't accept a 100-file PR from a new dev - don't accept it from AI |
13 | 13 | - Don't reverse decades of hard-won practices (DRY, small PRs, code ownership) just because AI makes it easy to generate code, these came about because things when wrong |
| 14 | +<<<<<<< HEAD |
14 | 15 | - PR reviews now take forever - too much volume for the eye to take in |
| 16 | +======= |
| 17 | +- PR reviews could take forever or just ignored - too much volume for the eye to take in |
| 18 | +>>>>>>> 3448a362 (add scope to performance scout) |
15 | 19 | - Open source/existing code has tests, is battle-hardened from real use, and edge cases are already solved - AI code has none of that |
16 | 20 |
|
17 | 21 | ## Practical Steps |
|
23 | 27 | - Sonar/jscpd can detect duplicated functions within the same PR |
24 | 28 | - Fail/warn on large new files (Danger.js or CI script to flag any new file over X lines) |
25 | 29 | - Fail/warn if a PR grows an existing file by more than Y lines |
| 30 | +<<<<<<< HEAD |
26 | 31 | - Manually viewing the PR is the last step but still important |
| 32 | +======= |
| 33 | +- Manually reviewing the PR is the last step but still important |
| 34 | +>>>>>>> 3448a362 (add scope to performance scout) |
27 | 35 |
|
28 | 36 | ## AI Doesn't Extend, It Recreates |
29 | 37 |
|
30 | 38 | - When adding to complex existing code, AI errs on the side of caution and recreates everything instead of extending |
31 | 39 | - Example: DSL-to-react-json-schema-form transformer - adding a new feature resulted in an 800+ line file that recreated all types (weaker), all functions (worse), instead of extending what was there |
32 | 40 | - Funny side effect: GitHub hides large files by default - I missed the 800 page monster in the PR review initially :) |
| 41 | +<<<<<<< HEAD |
| 42 | +======= |
| 43 | + |
| 44 | +## citations |
| 45 | + |
| 46 | +- [SonarSource blog on poor code quality growth in AI-accelerated codebases](https://www.sonarsource.com/blog/the-inevitable-rise-of-poor-code-quality-in-ai-accelerated-codebases) |
| 47 | +>>>>>>> 3448a362 (add scope to performance scout) |
0 commit comments