Skip to content

Commit d3d7671

Browse files
committed
add scope to performance scout
1 parent e07ed6d commit d3d7671

File tree

3 files changed

+24
-0
lines changed

3 files changed

+24
-0
lines changed

.changeset/large-deer-camp.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@cutting/performance-scout": minor
3+
---
4+
5+
add performance-scout to npm

packages/performance-scout/package.json

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,10 @@
11
{
22
"name": "@cutting/performance-scout",
3+
<<<<<<< HEAD
34
"version": "0.1.0",
5+
=======
6+
"version": "0.0.0",
7+
>>>>>>> 3448a362 (add scope to performance scout)
48
"type": "module",
59
"publishConfig": {
610
"access": "public"

plans/better-prs.md

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,11 @@
1111
- AI favours volume over precision and ownership
1212
- You wouldn't accept a 100-file PR from a new dev - don't accept it from AI
1313
- Don't reverse decades of hard-won practices (DRY, small PRs, code ownership) just because AI makes it easy to generate code, these came about because things when wrong
14+
<<<<<<< HEAD
1415
- PR reviews now take forever - too much volume for the eye to take in
16+
=======
17+
- PR reviews could take forever or just ignored - too much volume for the eye to take in
18+
>>>>>>> 3448a362 (add scope to performance scout)
1519
- Open source/existing code has tests, is battle-hardened from real use, and edge cases are already solved - AI code has none of that
1620

1721
## Practical Steps
@@ -23,10 +27,21 @@
2327
- Sonar/jscpd can detect duplicated functions within the same PR
2428
- Fail/warn on large new files (Danger.js or CI script to flag any new file over X lines)
2529
- Fail/warn if a PR grows an existing file by more than Y lines
30+
<<<<<<< HEAD
2631
- Manually viewing the PR is the last step but still important
32+
=======
33+
- Manually reviewing the PR is the last step but still important
34+
>>>>>>> 3448a362 (add scope to performance scout)
2735
2836
## AI Doesn't Extend, It Recreates
2937

3038
- When adding to complex existing code, AI errs on the side of caution and recreates everything instead of extending
3139
- Example: DSL-to-react-json-schema-form transformer - adding a new feature resulted in an 800+ line file that recreated all types (weaker), all functions (worse), instead of extending what was there
3240
- Funny side effect: GitHub hides large files by default - I missed the 800 page monster in the PR review initially :)
41+
<<<<<<< HEAD
42+
=======
43+
44+
## citations
45+
46+
- [SonarSource blog on poor code quality growth in AI-accelerated codebases](https://www.sonarsource.com/blog/the-inevitable-rise-of-poor-code-quality-in-ai-accelerated-codebases)
47+
>>>>>>> 3448a362 (add scope to performance scout)

0 commit comments

Comments
 (0)