Skip to content

Commit 406da4a

Browse files
committed
Update dagster-elasticsearch to use ty
1 parent a5ca71c commit 406da4a

4 files changed

Lines changed: 41 additions & 34 deletions

File tree

libraries/dagster-elasticsearch/Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,4 +12,4 @@ ruff:
1212
uv run ruff format
1313

1414
check:
15-
uv run pyright
15+
uv run ty check .

libraries/dagster-elasticsearch/dagster_elasticsearch_tests/conftest.py

Lines changed: 12 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
from collections.abc import Generator
44

55
import pytest
6+
from docker.errors import DockerException
67
from elasticsearch import Elasticsearch
78
from testcontainers.core.container import DockerContainer
89
from testcontainers.core.waiting_utils import wait_for_logs
@@ -29,14 +30,17 @@ def es_url() -> Generator[str, None, None]:
2930
yield override
3031
return
3132

32-
container = (
33-
DockerContainer(ES_IMAGE)
34-
.with_env("discovery.type", "single-node")
35-
.with_env("xpack.security.enabled", "false")
36-
.with_env("ES_JAVA_OPTS", "-Xms512m -Xmx512m")
37-
.with_exposed_ports(ES_PORT)
38-
)
39-
container.start()
33+
try:
34+
container = (
35+
DockerContainer(ES_IMAGE)
36+
.with_env("discovery.type", "single-node")
37+
.with_env("xpack.security.enabled", "false")
38+
.with_env("ES_JAVA_OPTS", "-Xms512m -Xmx512m")
39+
.with_exposed_ports(ES_PORT)
40+
)
41+
container.start()
42+
except DockerException as exc:
43+
pytest.skip(f"Docker unavailable for Elasticsearch integration tests: {exc}")
4044
try:
4145
wait_for_logs(container, "started")
4246
host = container.get_container_host_ip()

libraries/dagster-elasticsearch/pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,9 @@ dev = [
2424
"pandas>=2.0",
2525
"polars>=1.0",
2626
"pyarrow>=14",
27-
"pyright>=1.1.408",
2827
"pytest>=9.0.3",
2928
"ruff>=0.15.9",
29+
"ty==0.0.37",
3030
"testcontainers>=4.4.0",
3131
]
3232

libraries/dagster-elasticsearch/uv.lock

Lines changed: 27 additions & 24 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)