Skip to content

Commit 6a197e9

Browse files
Jcohen0102705815
andauthored
[dagster-dataform] Fix __init__.py imports (#229)
* [dagster-dataform] Initial README * [dagster-dataform] Root files * [dagster-dataform] Integration modules * [dagster-dataform] Integration unit tests * [dagster-dataform] Add prereq for freshness checks * [dagster-dataform] import module objects into __init__.py * [dagster-dataform] fix import names * [dagster-dataform] Resolve linting warnings. * [dagster-dataform] Add # noqa for stubborn type warnings * [dagster-dataform] Fix; remove non-existent function import * [dagster-dataform] Modify ignore comments to silence certain pyright errors. --------- Co-authored-by: 2705815 <Justin.Cohen2@aetna.com>
1 parent 7f3a37c commit 6a197e9

4 files changed

Lines changed: 6 additions & 7 deletions

File tree

libraries/dagster-dataform/dagster_dataform/__init__.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22
from dagster_dataform.resources import (
33
DataformRepositoryResource as DataformRepositoryResource,
44
load_dataform_assets as load_dataform_assets,
5-
load_dataform_asset_check_specs as load_dataform_asset_check_specs,
65
)
76
from dagster_dataform.dataform_polling_sensor import (
87
create_dataform_workflow_invocation_sensor as create_dataform_workflow_invocation_sensor,

libraries/dagster-dataform/dagster_dataform/resources.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -148,7 +148,7 @@ def query_workflow_invocation(
148148

149149
if not name:
150150
self.logger.error("No workflow invocation name available")
151-
return [] # noqa
151+
return [] # pyright: ignore[reportReturnType]
152152

153153
self.logger.info(f"Querying workflow invocation: {name}")
154154

@@ -163,7 +163,7 @@ def query_workflow_invocation(
163163
# self.logger.info(f"Found {len(response)} workflow invocation actions")
164164

165165
# Handle the response
166-
return response # noqa
166+
return response # pyright: ignore[reportReturnType]
167167

168168
def create_workflow_invocation(
169169
self, compilation_result_name: str
@@ -213,7 +213,7 @@ def load_dataform_assets(
213213
try:
214214
spec = AssetSpec(
215215
key=asset.target.name,
216-
kinds=["bigquery"], # noqa
216+
kinds=["bigquery"], # pyright: ignore[reportArgumentType]
217217
metadata={
218218
"Project ID": asset.target.database,
219219
"Dataset": asset.target.schema,

libraries/dagster-dataform/dagster_dataform_tests/test_dataform_orchestration_schedule.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ def test_dataform_orchestration_schedule_creates_schedule_and_job():
1414
repository_id="test-repo",
1515
location="us-central1",
1616
environment="dev",
17-
client=mock_dataform_client, # noqa
17+
client=mock_dataform_client, # pyright: ignore[reportArgumentType]
1818
)
1919

2020
schedule = create_dataform_orchestration_schedule(

libraries/dagster-dataform/dagster_dataform_tests/test_dataform_polling_sensor.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ def test_dataform_polling_sensor_creates_sensor_and_job():
1515
repository_id="test-repo",
1616
location="us-central1",
1717
environment="dev",
18-
client=mock_dataform_client, # noqa
18+
client=mock_dataform_client, # pyright: ignore[reportArgumentType]
1919
)
2020

2121
sensor = create_dataform_workflow_invocation_sensor(
@@ -36,7 +36,7 @@ def test_dataform_polling_sensor_creates_sensor_and_job_when_passed_job():
3636
repository_id="test-repo",
3737
location="us-central1",
3838
environment="dev",
39-
client=mock_dataform_client, # noqa
39+
client=mock_dataform_client, # pyright: ignore[reportArgumentType]
4040
)
4141

4242
@dg.job

0 commit comments

Comments
 (0)