Skip to content

Commit 7271c61

Browse files
committed
Fix dagster-openlineage imports for latest Dagster
1 parent 54cd7c5 commit 7271c61

4 files changed

Lines changed: 580 additions & 574 deletions

File tree

libraries/dagster-openlineage/dagster_openlineage/compat.py

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -14,11 +14,17 @@
1414
STEP_EVENTS = getattr(dagster, "STEP_EVENTS", None)
1515

1616
if PIPELINE_EVENTS is None or STEP_EVENTS is None:
17-
_core_events_spec = importlib.util.find_spec("dagster.core.events")
18-
if _core_events_spec is not None:
19-
_core_events_module = importlib.import_module("dagster.core.events")
20-
PIPELINE_EVENTS = getattr(_core_events_module, "PIPELINE_EVENTS", set())
21-
STEP_EVENTS = getattr(_core_events_module, "STEP_EVENTS", set())
17+
for _core_events_module_name in ("dagster._core.events", "dagster.core.events"):
18+
try:
19+
_core_events_spec = importlib.util.find_spec(_core_events_module_name)
20+
except ModuleNotFoundError:
21+
_core_events_spec = None
22+
23+
if _core_events_spec is not None:
24+
_core_events_module = importlib.import_module(_core_events_module_name)
25+
PIPELINE_EVENTS = getattr(_core_events_module, "PIPELINE_EVENTS", set())
26+
STEP_EVENTS = getattr(_core_events_module, "STEP_EVENTS", set())
27+
break
2228
else:
2329
PIPELINE_EVENTS = set()
2430
STEP_EVENTS = set()

libraries/dagster-openlineage/dagster_openlineage_tests/test_e2e_asset_emission.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@
5151
from dagster._core.execution.plan.objects import StepFailureData
5252
from dagster._core.instance import DagsterInstance
5353
from dagster._core.storage.event_log import InMemoryEventLogStorage
54-
from dagster.core.test_utils import instance_for_test
54+
from dagster._core.test_utils import instance_for_test
5555
from openlineage.client import OpenLineageClient
5656
from openlineage.client.event_v2 import DatasetEvent, RunEvent, RunState
5757
from openlineage.client.generated.schema_dataset import SchemaDatasetFacet
@@ -385,7 +385,7 @@ def test_sensor_emits_asset_ol_events_from_real_execution():
385385
temp_dir=temp_dir,
386386
overrides={
387387
"event_log_storage": {
388-
"module": "dagster.core.storage.event_log",
388+
"module": "dagster._core.storage.event_log",
389389
"class": "ConsolidatedSqliteEventLogStorage",
390390
"config": {"base_dir": temp_dir},
391391
},

libraries/dagster-openlineage/dagster_openlineage_tests/test_sensor_cursor.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414

1515
from dagster_openlineage.compat import DagsterEventType, SensorDefinition
1616
from dagster import build_sensor_context
17-
from dagster.core.test_utils import instance_for_test
17+
from dagster._core.test_utils import instance_for_test
1818

1919
from .conftest import make_test_event_log_record
2020

0 commit comments

Comments
 (0)