Skip to content

Commit b064b37

Browse files
Release 1.13.5 (tracks c06a58b31e4ad0e3d82ac723be753398f134c5f8)
1 parent 8dbf972 commit b064b37

29 files changed

Lines changed: 146 additions & 113 deletions

File tree

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
__version__ = "1.13.4"
1+
__version__ = "1.13.5"

dagster-cloud-examples/pyproject.toml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ build-backend = "hatchling.build"
77
[project]
88
name = "dagster-cloud-examples"
99
requires-python = ">=3.9,<3.13"
10-
version = "1.13.4"
10+
version = "1.13.5"
1111
authors = [
1212
{ name = "Elementl", email = "hello@elementl.com" },
1313
]
@@ -17,7 +17,7 @@ classifiers = [
1717
"Operating System :: OS Independent",
1818
]
1919
dependencies = [
20-
"dagster-cloud==1.13.4",
20+
"dagster-cloud==1.13.5",
2121
]
2222

2323
[project.license]

dagster-cloud/dagster_cloud/agent/dagster_cloud_agent.py

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -259,7 +259,7 @@ def _update_agent_resource_limits(
259259

260260
self._utilization_metrics["resource_limits"][
261261
user_code_launcher.user_code_deployment_type.value
262-
] = limits # type: ignore
262+
] = limits # pyright: ignore[reportGeneralTypeIssues]
263263

264264
def _update_utilization_metrics(self, user_code_launcher: DagsterCloudUserCodeLauncher):
265265
container_utilization_metrics = retrieve_containerized_utilization_metrics(
@@ -298,8 +298,10 @@ def run_loop(
298298
# for old agents, and only will work if there's a single deployment in the org)
299299
result = self._instance.graphql_client.execute(DEPLOYMENT_INFO_QUERY)
300300
deployment_name = result["data"]["deploymentInfo"]["deploymentName"]
301-
self._instance = self._exit_stack.enter_context(
302-
DagsterInstance.from_ref(self._instance.ref_for_deployment(deployment_name)) # type: ignore # (instance subclass)
301+
self._instance = self._exit_stack.enter_context( # ty: ignore[invalid-assignment] # pyright: ignore[reportAttributeAccessIssue]
302+
DagsterInstance.from_ref(
303+
self._instance.ref_for_deployment(deployment_name)
304+
) # (instance subclass)
303305
)
304306

305307
self._check_initial_deployment_names()

dagster-cloud/dagster_cloud/dagster_insights/bigquery/bigquery_utils.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,5 +23,5 @@ def build_bigquery_cost_metadata(
2323
BIGQUERY_METADATA_SLOTS_MS: slots_ms,
2424
}
2525
if job_ids:
26-
metadata[BIGQUERY_METADATA_JOB_IDS] = job_ids
26+
metadata[BIGQUERY_METADATA_JOB_IDS] = job_ids # ty: ignore[invalid-assignment]
2727
return metadata

dagster-cloud/dagster_cloud/dagster_insights/bigquery/dbt_wrapper.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -167,7 +167,7 @@ def jaffle_shop_dbt_assets(
167167
cost_by_asset = defaultdict(list)
168168
try:
169169
with adapter.connection_named("dagster_insights:bigquery_cost"):
170-
client: bigquery.Client = adapter.connections.get_thread_connection().handle # pyright: ignore[reportAssignmentType]
170+
client: bigquery.Client = adapter.connections.get_thread_connection().handle
171171

172172
if (client.location or adapter.config.credentials.location) and client.project:
173173
# we should populate the location/project from the client, and use that to determine

dagster-cloud/dagster_cloud/dagster_insights/snowflake/insights_snowflake_resource.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ def __init__(self, *args, asset_key: AssetKey | None = None, **kwargs) -> None:
6363
self._asset_key = asset_key
6464
super().__init__(*args, **kwargs)
6565

66-
def execute_string( # pyright: ignore[reportIncompatibleMethodOverride], fix me!
66+
def execute_string( # ty: ignore[invalid-method-override], fix me!
6767
self,
6868
sql_text: str,
6969
remove_comments: bool = False,
@@ -79,7 +79,7 @@ def execute_string( # pyright: ignore[reportIncompatibleMethodOverride], fix me
7979
**kwargs,
8080
)
8181

82-
def execute_stream( # pyright: ignore[reportIncompatibleMethodOverride], fix me!
82+
def execute_stream( # ty: ignore[invalid-method-override], fix me!
8383
self,
8484
stream: StringIO,
8585
remove_comments: bool = False,

dagster-cloud/dagster_cloud/execution/cloud_run_launcher/k8s.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,5 +5,5 @@ class CloudK8sRunLauncher(K8sRunLauncher):
55
# Avoid call to `count_resume_run_attempts`, since resuming runs is not currently
66
# supported in cloud and the method makes repeated event log calls.
77
@property
8-
def supports_run_worker_crash_recovery(self): # pyright: ignore[reportIncompatibleMethodOverride]
8+
def supports_run_worker_crash_recovery(self):
99
return False

dagster-cloud/dagster_cloud/execution/cloud_run_launcher/process.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ def join(self, timeout=30):
5959
for run_id in self._run_ids
6060
if (
6161
self._instance.get_run_by_id(run_id)
62-
and not self._instance.get_run_by_id(run_id).is_finished # pyright: ignore[reportOptionalMemberAccess]
62+
and not self._instance.get_run_by_id(run_id).is_finished # ty: ignore[unresolved-attribute]
6363
)
6464
]
6565

dagster-cloud/dagster_cloud/instance/__init__.py

Lines changed: 12 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -226,7 +226,7 @@ def create_graphql_client(
226226
return create_agent_graphql_client(
227227
self.client_managed_retries_requests_session,
228228
self.dagster_cloud_graphql_url,
229-
self._dagster_cloud_api_config, # pyright: ignore[reportArgumentType]
229+
self._dagster_cloud_api_config,
230230
scope=scope,
231231
)
232232

@@ -309,7 +309,7 @@ def http_client(self):
309309
if self._http_client is None:
310310
self._http_client = create_agent_http_client(
311311
self.client_managed_retries_requests_session,
312-
self._dagster_cloud_api_config, # pyright: ignore[reportArgumentType]
312+
self._dagster_cloud_api_config,
313313
scope=DagsterCloudInstanceScope.DEPLOYMENT,
314314
)
315315

@@ -422,7 +422,7 @@ def dagster_cloud_code_location_update_result_url(self):
422422
return f"{self.dagster_cloud_url}/code_location_update_result"
423423

424424
def dagster_cloud_api_headers(self, scope: DagsterCloudInstanceScope):
425-
return get_agent_headers(self._dagster_cloud_api_config, scope=scope) # pyright: ignore[reportArgumentType]
425+
return get_agent_headers(self._dagster_cloud_api_config, scope=scope)
426426

427427
@property
428428
def dagster_cloud_agent_token(self) -> str:
@@ -445,7 +445,7 @@ def dagster_cloud_api_timeout(self) -> int:
445445
def dagster_cloud_api_proxies(self) -> dict[str, str] | None:
446446
# Requests library modifies the proxies key so create a copy
447447
return (
448-
self._dagster_cloud_api_config.get("proxies").copy() # pyright: ignore[reportOptionalMemberAccess]
448+
self._dagster_cloud_api_config.get("proxies").copy()
449449
if self._dagster_cloud_api_config.get("proxies")
450450
else {}
451451
)
@@ -598,22 +598,23 @@ def config_defaults(base_dir):
598598

599599
empty_yaml = yaml.dump({})
600600

601-
defaults["run_storage"] = ConfigurableClassData( # pyright: ignore[reportIndexIssue]
601+
# `defaults` is typed `Mapping[...]` upstream but is a mutable dict at runtime.
602+
defaults["run_storage"] = ConfigurableClassData( # ty: ignore[invalid-assignment]
602603
"dagster_cloud.storage.runs",
603604
"GraphQLRunStorage",
604605
empty_yaml,
605606
)
606-
defaults["event_log_storage"] = ConfigurableClassData( # pyright: ignore[reportIndexIssue]
607+
defaults["event_log_storage"] = ConfigurableClassData( # ty: ignore[invalid-assignment]
607608
"dagster_cloud.storage.event_logs",
608609
"GraphQLEventLogStorage",
609610
empty_yaml,
610611
)
611-
defaults["schedule_storage"] = ConfigurableClassData( # pyright: ignore[reportIndexIssue]
612+
defaults["schedule_storage"] = ConfigurableClassData( # ty: ignore[invalid-assignment]
612613
"dagster_cloud.storage.schedules",
613614
"GraphQLScheduleStorage",
614615
empty_yaml,
615616
)
616-
defaults["storage"] = ConfigurableClassData( # pyright: ignore[reportIndexIssue]
617+
defaults["storage"] = ConfigurableClassData( # ty: ignore[invalid-assignment]
617618
module_name="dagster._core.storage.legacy_storage",
618619
class_name="CompositeStorage",
619620
config_yaml=yaml.dump(
@@ -638,15 +639,15 @@ def config_defaults(base_dir):
638639
),
639640
)
640641

641-
defaults["compute_logs"] = ConfigurableClassData( # pyright: ignore[reportIndexIssue]
642+
defaults["compute_logs"] = ConfigurableClassData( # ty: ignore[invalid-assignment]
642643
"dagster_cloud.storage.compute_logs", "CloudComputeLogManager", empty_yaml
643644
)
644645

645-
defaults["secrets"] = ConfigurableClassData( # pyright: ignore[reportIndexIssue]
646+
defaults["secrets"] = ConfigurableClassData( # ty: ignore[invalid-assignment]
646647
"dagster_cloud.secrets", "DagsterCloudSecretsLoader", empty_yaml
647648
)
648649

649-
defaults["defs_state_storage"] = ConfigurableClassData( # pyright: ignore[reportIndexIssue]
650+
defaults["defs_state_storage"] = ConfigurableClassData( # ty: ignore[invalid-assignment]
650651
"dagster_cloud.storage.defs_state", "GraphQLDefsStateStorage", empty_yaml
651652
)
652653

dagster-cloud/dagster_cloud/metadata/source_code.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ def _locate_git_root() -> Path | None:
3636
elif code_origin.python_file:
3737
code_origin_filepath = code_origin.python_file
3838

39-
if not code_origin_filepath: # pyright: ignore[reportPossiblyUnboundVariable]
39+
if not code_origin_filepath:
4040
return None
4141
current_dir = Path(code_origin_filepath)
4242
for parent in current_dir.parents:

0 commit comments

Comments
 (0)