-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Expand file tree
/
Copy pathcontainer_context.py
More file actions
570 lines (490 loc) · 22.2 KB
/
Copy pathcontainer_context.py
File metadata and controls
570 lines (490 loc) · 22.2 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
import copy
import logging
from collections.abc import Mapping, Sequence
from typing import TYPE_CHECKING, Any, NamedTuple, Optional, cast
import dagster._check as check
import kubernetes.client
from dagster._config import process_config
from dagster._core.container_context import process_shared_container_context_config
from dagster._core.errors import DagsterInvalidConfigError
from dagster._core.storage.dagster_run import DagsterRun
from dagster._core.utils import parse_env_var
from dagster_shared.utils.hash import hash_collection
if TYPE_CHECKING:
from dagster_k8s import K8sRunLauncher
from dagster_k8s.job import (
DagsterK8sJobConfig,
K8sConfigMergeBehavior,
UserDefinedDagsterK8sConfig,
get_user_defined_k8s_config,
)
from dagster_k8s.models import k8s_snake_case_dict, k8s_snake_case_keys
def _dedupe_list(values):
new_list = []
hashes = set()
for value in values:
value_hash = hash_collection(value) if isinstance(value, (list, dict)) else hash(value)
if value_hash not in hashes:
hashes.add(value_hash)
new_list.append(value)
return new_list
ALWAYS_SHALLOW_MERGE_LIST_FIELDS = {
"command",
"args",
}
class K8sContainerContext(
NamedTuple(
"_K8sContainerContext",
[
("server_k8s_config", UserDefinedDagsterK8sConfig),
("run_k8s_config", UserDefinedDagsterK8sConfig),
("namespace", str | None),
("server_replica_count", int | None),
],
)
):
"""Encapsulates configuration that can be applied to a K8s job running Dagster code.
Can be persisted on a DagsterRun at run submission time based on metadata from the
code location and then included in the job's configuration at run launch time or step
launch time.
"""
def __new__(
cls,
image_pull_policy: str | None = None,
image_pull_secrets: Sequence[Mapping[str, str]] | None = None,
service_account_name: str | None = None,
env_config_maps: Sequence[str] | None = None,
env_secrets: Sequence[str] | None = None,
env_vars: Sequence[str] | None = None,
volume_mounts: Sequence[Mapping[str, Any]] | None = None,
volumes: Sequence[Mapping[str, Any]] | None = None,
labels: Mapping[str, str] | None = None,
namespace: str | None = None,
resources: Mapping[str, Any] | None = None,
scheduler_name: str | None = None,
security_context: Mapping[str, Any] | None = None,
server_k8s_config: UserDefinedDagsterK8sConfig | None = None,
run_k8s_config: UserDefinedDagsterK8sConfig | None = None,
env: Sequence[Mapping[str, Any]] | None = None,
server_replica_count: int | None = None,
):
top_level_k8s_config = K8sContainerContext._get_base_user_defined_k8s_config(
image_pull_policy=check.opt_str_param(image_pull_policy, "image_pull_policy"),
image_pull_secrets=check.opt_sequence_param(image_pull_secrets, "image_pull_secrets"),
service_account_name=check.opt_str_param(service_account_name, "service_account_name"),
env_config_maps=check.opt_sequence_param(env_config_maps, "env_config_maps"),
env_secrets=check.opt_sequence_param(env_secrets, "env_secrets"),
env_vars=check.opt_sequence_param(env_vars, "env_vars"),
volume_mounts=[
k8s_snake_case_dict(kubernetes.client.V1VolumeMount, mount)
for mount in check.opt_sequence_param(volume_mounts, "volume_mounts")
],
volumes=[
k8s_snake_case_dict(kubernetes.client.V1Volume, volume)
for volume in check.opt_sequence_param(volumes, "volumes")
],
labels=check.opt_mapping_param(labels, "labels"),
resources=check.opt_mapping_param(resources, "resources"),
scheduler_name=check.opt_str_param(scheduler_name, "scheduler_name"),
security_context=check.opt_mapping_param(security_context, "security_context"),
env=[
k8s_snake_case_dict(kubernetes.client.V1EnvVar, e)
for e in check.opt_sequence_param(env, "env")
],
)
run_k8s_config = K8sContainerContext._merge_k8s_config(
top_level_k8s_config._replace(
deployment_metadata={},
service_metadata={},
service_spec_config={},
),
run_k8s_config or UserDefinedDagsterK8sConfig.from_dict({}),
)
server_k8s_config = K8sContainerContext._merge_k8s_config(
top_level_k8s_config._replace(
job_config={},
job_metadata={},
job_spec_config={},
),
server_k8s_config or UserDefinedDagsterK8sConfig.from_dict({}),
)
return super().__new__(
cls,
run_k8s_config=run_k8s_config,
server_k8s_config=server_k8s_config,
namespace=namespace,
server_replica_count=check.opt_int_param(server_replica_count, "server_replica_count"),
)
@staticmethod
def _get_base_user_defined_k8s_config(
image_pull_policy: str | None,
image_pull_secrets: Sequence[Mapping[str, str]] | None,
service_account_name: str | None,
env_config_maps: Sequence[str],
env_secrets: Sequence[str],
env_vars: Sequence[str],
volume_mounts: Sequence[Mapping[str, Any]],
volumes: Sequence[Mapping[str, Any]],
labels: Mapping[str, str],
resources: Mapping[str, Any],
scheduler_name: str | None,
security_context: Mapping[str, Any],
env: Sequence[Mapping[str, Any]],
) -> UserDefinedDagsterK8sConfig:
container_config = {}
pod_spec_config = {}
pod_template_spec_metadata = {}
job_metadata = {}
deployment_metadata = {}
service_metadata = {}
if volume_mounts:
container_config["volume_mounts"] = volume_mounts
if resources:
container_config["resources"] = resources
if image_pull_secrets:
pod_spec_config["image_pull_secrets"] = image_pull_secrets
if volumes:
pod_spec_config["volumes"] = volumes
if labels:
pod_template_spec_metadata["labels"] = labels
job_metadata["labels"] = labels
deployment_metadata["labels"] = labels
service_metadata["labels"] = labels
if image_pull_policy:
container_config["image_pull_policy"] = image_pull_policy
if service_account_name:
pod_spec_config["service_account_name"] = service_account_name
env_from = [{"config_map_ref": {"name": config_map}} for config_map in env_config_maps]
env_from.extend([{"secret_ref": {"name": secret}} for secret in env_secrets])
if env_from:
container_config["env_from"] = env_from
parsed_env_vars = [parse_env_var(key) for key in env_vars]
container_config_env = [
{"name": parsed_env_var[0], "value": parsed_env_var[1]}
for parsed_env_var in parsed_env_vars
]
container_config_env.extend([{**v} for v in env])
if container_config_env:
container_config["env"] = container_config_env
if scheduler_name:
pod_spec_config["scheduler_name"] = scheduler_name
if security_context:
container_config["security_context"] = security_context
return UserDefinedDagsterK8sConfig(
container_config=container_config,
pod_spec_config=pod_spec_config,
pod_template_spec_metadata=pod_template_spec_metadata,
job_metadata=job_metadata,
service_metadata=service_metadata,
deployment_metadata=deployment_metadata,
)
@staticmethod
def _merge_k8s_config(
onto_config: UserDefinedDagsterK8sConfig,
from_config: UserDefinedDagsterK8sConfig,
) -> UserDefinedDagsterK8sConfig:
merge_behavior = from_config.merge_behavior
onto_dict = onto_config.to_dict()
from_dict = from_config.to_dict()
assert set(onto_dict) == set(from_dict)
if merge_behavior == K8sConfigMergeBehavior.DEEP:
onto_dict = copy.deepcopy(onto_dict)
merged_dict = K8sContainerContext._deep_merge_k8s_config(
onto_dict=onto_dict, from_dict=from_dict
)
else:
merged_dict = {
key: (
{**onto_dict[key], **from_dict[key]}
if isinstance(onto_dict[key], dict)
else from_dict[key]
)
for key in onto_dict
}
return UserDefinedDagsterK8sConfig.from_dict(merged_dict)
@staticmethod
def _deep_merge_k8s_config(onto_dict: dict[str, Any], from_dict: Mapping[str, Any]):
for from_key, from_value in from_dict.items():
if from_key not in onto_dict:
onto_dict[from_key] = from_value
else:
onto_value = onto_dict[from_key]
if (
isinstance(from_value, list)
and from_key not in ALWAYS_SHALLOW_MERGE_LIST_FIELDS
):
check.invariant(isinstance(onto_value, list))
onto_dict[from_key] = _dedupe_list([*onto_value, *from_value])
elif isinstance(from_value, dict):
check.invariant(isinstance(onto_value, dict))
onto_dict[from_key] = K8sContainerContext._deep_merge_k8s_config(
onto_value, from_value
)
else:
onto_dict[from_key] = from_value
return onto_dict
def merge(
self,
other: "K8sContainerContext",
) -> "K8sContainerContext":
return K8sContainerContext(
server_k8s_config=self._merge_k8s_config(
self.server_k8s_config, other.server_k8s_config
),
run_k8s_config=self._merge_k8s_config(self.run_k8s_config, other.run_k8s_config),
namespace=other.namespace if other.namespace else self.namespace,
server_replica_count=other.server_replica_count
if other.server_replica_count is not None
else self.server_replica_count,
)
def _snake_case_allowed_fields(
self, only_allow_user_defined_k8s_config_fields: Mapping[str, Any]
) -> Mapping[str, Any]:
result = {}
for key in only_allow_user_defined_k8s_config_fields:
if key == "namespace":
result[key] = only_allow_user_defined_k8s_config_fields[key]
continue
if key == "container_config":
model_class = kubernetes.client.V1Container
elif key in {
"job_metadata",
"pod_template_spec_metadata",
"deployment_metadata",
"service_metadata",
}:
model_class = kubernetes.client.V1ObjectMeta
elif key == "pod_spec_config":
model_class = kubernetes.client.V1PodSpec
elif key == "job_spec_config":
model_class = kubernetes.client.V1JobSpec
elif key == "service_spec_config":
model_class = kubernetes.client.V1ServiceSpec
else:
raise Exception(f"Unexpected key in allowlist {key}")
result[key] = k8s_snake_case_keys(
model_class, only_allow_user_defined_k8s_config_fields[key]
)
return result
def validate_user_k8s_config_for_run(
self,
only_allow_user_defined_k8s_config_fields: Mapping[str, Any] | None,
only_allow_user_defined_env_vars: Sequence[str] | None,
):
return self._validate_user_k8s_config(
self.run_k8s_config,
only_allow_user_defined_k8s_config_fields,
only_allow_user_defined_env_vars,
)
def validate_user_k8s_config_for_code_server(
self,
only_allow_user_defined_k8s_config_fields: Mapping[str, Any] | None,
only_allow_user_defined_env_vars: Sequence[str] | None,
):
return self._validate_user_k8s_config(
self.server_k8s_config,
only_allow_user_defined_k8s_config_fields,
only_allow_user_defined_env_vars,
)
def _validate_user_k8s_config(
self,
user_defined_k8s_config: UserDefinedDagsterK8sConfig,
only_allow_user_defined_k8s_config_fields: Mapping[str, Any] | None,
only_allow_user_defined_env_vars: Sequence[str] | None,
) -> "K8sContainerContext":
used_fields = self._get_used_k8s_config_fields(user_defined_k8s_config)
if only_allow_user_defined_k8s_config_fields is not None:
snake_case_allowlist = self._snake_case_allowed_fields(
only_allow_user_defined_k8s_config_fields
)
disallowed_fields = []
for key, used_fields_with_key in used_fields.items():
if isinstance(used_fields_with_key, set):
disallowed_fields.extend(
f"{key}.{used_field}"
for used_field in used_fields_with_key
if not snake_case_allowlist.get(key, {}).get(used_field)
)
else:
check.invariant(isinstance(used_fields_with_key, bool))
if used_fields_with_key and not only_allow_user_defined_k8s_config_fields.get(
key
):
disallowed_fields.append(key)
if disallowed_fields:
raise Exception(
f"Attempted to create a pod with fields that violated the allowed list: {', '.join(disallowed_fields)}"
)
validated_container_context = self
if only_allow_user_defined_env_vars is not None:
validated_container_context = self._filter_user_defined_env_vars(
set(only_allow_user_defined_env_vars)
)
return validated_container_context
def _filter_user_defined_k8s_config_env_vars(
self,
user_defined_k8s_config: UserDefinedDagsterK8sConfig,
only_allow_user_defined_env_vars: set[str],
discarded_env_var_names: set[str],
) -> UserDefinedDagsterK8sConfig:
"""Filters out any env vars from the supplied UserDefinedDagsterK8sConfig
that are not in the supplied set of env var names and adds the names of
any env vars that were discarded to the passed-in discarded_env_var_names set.
"""
if "env" not in user_defined_k8s_config.container_config:
return user_defined_k8s_config
filtered_env = []
for env_dict in user_defined_k8s_config.container_config["env"]:
env_key = env_dict["name"]
if env_key in only_allow_user_defined_env_vars:
filtered_env.append(env_dict)
else:
discarded_env_var_names.add(env_key)
return UserDefinedDagsterK8sConfig.from_dict(
{
**user_defined_k8s_config.to_dict(),
"container_config": {
**user_defined_k8s_config.container_config,
"env": filtered_env,
},
}
)
def _filter_user_defined_env_vars(
self,
only_allow_user_defined_env_vars: set[str],
) -> "K8sContainerContext":
discarded_env_var_names = set()
new_run_k8s_config = self._filter_user_defined_k8s_config_env_vars(
self.run_k8s_config,
only_allow_user_defined_env_vars,
discarded_env_var_names,
)
new_server_k8s_config = self._filter_user_defined_k8s_config_env_vars(
self.server_k8s_config,
only_allow_user_defined_env_vars,
discarded_env_var_names,
)
if discarded_env_var_names:
logging.warning(
f"Excluding the following environment variables because they are not in the allowlist for user-defined environment variables: {', '.join(discarded_env_var_names)}"
)
return self._replace(
run_k8s_config=new_run_k8s_config,
server_k8s_config=new_server_k8s_config,
)
def _get_used_k8s_config_fields(
self, user_defined_k8s_config: UserDefinedDagsterK8sConfig
) -> Mapping[str, Mapping[str, set[str]]]:
used_fields = {}
for key, fields in user_defined_k8s_config.to_dict().items():
if key == "merge_behavior":
continue
used_fields[key] = used_fields.get(key, set()).union(
{field_key for field_key in fields}
)
if self.namespace:
used_fields["namespace"] = True
return used_fields
@staticmethod
def create_for_run(
dagster_run: DagsterRun,
run_launcher: Optional["K8sRunLauncher"],
include_run_tags: bool,
) -> "K8sContainerContext":
context = K8sContainerContext()
if run_launcher:
context = context.merge(
K8sContainerContext(
image_pull_policy=run_launcher.image_pull_policy,
image_pull_secrets=run_launcher.image_pull_secrets,
service_account_name=run_launcher.service_account_name,
env_config_maps=run_launcher.env_config_maps,
env_secrets=run_launcher.env_secrets,
env_vars=run_launcher.env_vars,
volume_mounts=run_launcher.volume_mounts,
volumes=run_launcher.volumes,
labels=run_launcher.labels,
namespace=run_launcher.job_namespace,
resources=run_launcher.resources,
scheduler_name=run_launcher.scheduler_name,
security_context=run_launcher.security_context,
run_k8s_config=UserDefinedDagsterK8sConfig.from_dict(
run_launcher.run_k8s_config or {}
),
)
)
user_defined_container_context = K8sContainerContext()
if dagster_run.job_code_origin:
run_container_context = dagster_run.job_code_origin.repository_origin.container_context
if run_container_context:
user_defined_container_context = user_defined_container_context.merge(
K8sContainerContext.create_from_config(run_container_context)
)
if include_run_tags:
user_defined_k8s_config = get_user_defined_k8s_config(dagster_run.tags)
user_defined_container_context = user_defined_container_context.merge(
K8sContainerContext(run_k8s_config=user_defined_k8s_config)
)
if run_launcher:
user_defined_container_context = (
user_defined_container_context.validate_user_k8s_config_for_run(
run_launcher.only_allow_user_defined_k8s_config_fields,
run_launcher.only_allow_user_defined_env_vars,
)
)
return user_defined_container_context.merge(context)
@staticmethod
def create_from_config(run_container_context) -> "K8sContainerContext":
processed_shared_container_context = process_shared_container_context_config(
run_container_context or {}
)
shared_container_context = K8sContainerContext(
env_vars=processed_shared_container_context.get("env_vars", [])
)
run_k8s_container_context = (
run_container_context.get("k8s", {}) if run_container_context else {}
)
if not run_k8s_container_context:
return shared_container_context
processed_container_context = process_config(
DagsterK8sJobConfig.config_type_container_context(), run_k8s_container_context
)
if not processed_container_context.success:
raise DagsterInvalidConfigError(
"Errors while parsing k8s container context",
processed_container_context.errors,
run_k8s_container_context,
)
processed_context_value = cast("dict", processed_container_context.value)
return shared_container_context.merge(
K8sContainerContext(
image_pull_policy=processed_context_value.get("image_pull_policy"),
image_pull_secrets=processed_context_value.get("image_pull_secrets"),
service_account_name=processed_context_value.get("service_account_name"),
env_config_maps=processed_context_value.get("env_config_maps"),
env_secrets=processed_context_value.get("env_secrets"),
env_vars=processed_context_value.get("env_vars"),
volume_mounts=processed_context_value.get("volume_mounts"),
volumes=processed_context_value.get("volumes"),
labels=processed_context_value.get("labels"),
namespace=processed_context_value.get("namespace"),
resources=processed_context_value.get("resources"),
scheduler_name=processed_context_value.get("scheduler_name"),
security_context=processed_context_value.get("security_context"),
server_k8s_config=UserDefinedDagsterK8sConfig.from_dict(
processed_context_value.get("server_k8s_config", {})
),
run_k8s_config=UserDefinedDagsterK8sConfig.from_dict(
processed_context_value.get("run_k8s_config", {})
),
env=processed_context_value.get("env"),
server_replica_count=processed_context_value.get("server_replica_count"),
),
)
def get_k8s_job_config(self, job_image, run_launcher) -> DagsterK8sJobConfig:
return DagsterK8sJobConfig(
job_image=job_image if job_image else run_launcher.job_image,
dagster_home=run_launcher.dagster_home,
instance_config_map=run_launcher.instance_config_map,
postgres_password_secret=run_launcher.postgres_password_secret,
)