Skip to content

Commit 1384678

Browse files
authored
fast follow test fixes for code location tag change (#33098)
## Summary & Motivation fix tests... once #32715 lands, we can change the base to `master` and land this ## How I Tested These Changes BK ## Changelog > Insert changelog entry or delete this section.
1 parent c0dde6f commit 1384678

2 files changed

Lines changed: 14 additions & 3 deletions

File tree

python_modules/dagster-graphql/dagster_graphql_tests/graphql/__snapshots__/test_reexecution.ambr

Lines changed: 8 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

python_modules/libraries/dagster-aws/dagster_aws_tests/ecs_tests/launcher_tests/test_launching.py

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,8 @@ def test_default_launcher(
3939
task_long_arn_format,
4040
):
4141
ecs.put_account_setting(name="taskLongArnFormat", value=task_long_arn_format)
42-
assert not run.tags
42+
assert "ecs/task_arn" not in run.tags
43+
assert "ecs/cluster" not in run.tags
4344

4445
initial_task_definitions = ecs.list_task_definitions()["taskDefinitionArns"]
4546
initial_tasks = ecs.list_tasks()["taskArns"]
@@ -213,7 +214,8 @@ def test_launcher_dont_use_current_task(
213214
cluster = instance.run_launcher.run_task_kwargs["cluster"]
214215
assert cluster == "my_cluster"
215216

216-
assert not run.tags
217+
assert "ecs/task_arn" not in run.tags
218+
assert "ecs/cluster" not in run.tags
217219

218220
initial_task_definitions = ecs.list_task_definitions()["taskDefinitionArns"]
219221
initial_tasks = ecs.list_tasks(cluster=cluster)["taskArns"]
@@ -1444,7 +1446,8 @@ def test_custom_launcher(
14441446
custom_workspace,
14451447
custom_run,
14461448
):
1447-
assert not custom_run.tags
1449+
assert "ecs/task_arn" not in custom_run.tags
1450+
assert "ecs/cluster" not in custom_run.tags
14481451

14491452
initial_tasks = ecs.list_tasks()["taskArns"]
14501453

0 commit comments

Comments
 (0)