pyright

Author: anuthebananu

python_modules/dagster/dagster/_core/definitions/asset_spec.py

@@ -461,5 +461,5 @@ def attach_internal_freshness_policy(spec: AssetSpec, policy: InternalFreshnessP
     You can use this in Definitions.map_asset_specs to attach a freshness policy to an asset spec.
     """
     return spec.merge_attributes(
-        metadata={INTERNAL_FRESHNESS_POLICY_METADATA_KEY: serialize_value(policy)}
+        metadata={INTERNAL_FRESHNESS_POLICY_METADATA_KEY: serialize_value(policy)}  # pyright: ignore[reportArgumentType]
     )

python_modules/dagster/dagster/_core/definitions/freshness.py

@@ -38,7 +38,7 @@ def from_asset_spec_metadata(
         serialized_policy = metadata.get(INTERNAL_FRESHNESS_POLICY_METADATA_KEY)
         if serialized_policy is None:
             return None
-        return deserialize_value(serialized_policy.value, cls)
+        return deserialize_value(serialized_policy.value, cls)  # pyright: ignore
 
     @staticmethod
     def time_window(

python_modules/dagster/dagster_tests/asset_defs_tests/test_internal_freshness.py

@@ -1,4 +1,5 @@
 from datetime import timedelta
+from typing import Union
 
 from dagster._core.definitions.asset_key import AssetKey
 from dagster._core.definitions.asset_spec import AssetSpec, attach_internal_freshness_policy
@@ -137,8 +138,9 @@ def foo_asset():
     )
 
     assets_and_specs = mapped_defs.assets
-    assert len(assets_and_specs) == 3
+    assert assets_and_specs is not None
     for asset_or_spec in assets_and_specs:
+        assert isinstance(asset_or_spec, Union[AssetsDefinition, AssetSpec])
         spec = (
             asset_or_spec.get_asset_spec()
             if isinstance(asset_or_spec, AssetsDefinition)

python_modules/libraries/dagster-azure/dagster_azure/adls2/io_manager.py

@@ -90,7 +90,7 @@ def _acquire_lease(self, client: Any, is_rm: bool = False) -> Iterator[str]:
         lease_client = self.lease_client_constructor(client=client)
         try:
             # Unclear why this needs to be type-ignored
-            lease_client.acquire(lease_duration=self.lease_duration)  # type: ignore
+            lease_client.acquire(lease_duration=self.lease_duration)
             yield lease_client.id
         finally:
             # cannot release a lease on a file that no longer exists, so need to check