[ui] Remove the “faceted assets” feature flag

Author: bengotow

js_modules/dagster-ui/packages/ui-core/src/app/DefaultFeatureFlags.oss.tsx

@@ -4,7 +4,6 @@ import {FeatureFlag} from 'shared/app/FeatureFlags.oss';
  * Default values for feature flags when they are unset.
  */
 export const DEFAULT_FEATURE_FLAG_VALUES: Partial<Record<FeatureFlag, boolean>> = {
-  [FeatureFlag.flagAssetNodeFacets]: true,
   [FeatureFlag.flagNavigationUpdate]: true,
   [FeatureFlag.flagAssetCatalogSidebar]: true,
 

js_modules/dagster-ui/packages/ui-core/src/app/FeatureFlags.oss.tsx

@@ -3,7 +3,6 @@ export enum FeatureFlag {
   flagDisableWebsockets = 'flagDisableWebsockets',
   flagSidebarResources = 'flagSidebarResources',
   flagDisableAutoLoadDefaults = 'flagDisableAutoLoadDefaults',
-  flagAssetNodeFacets = 'flagAssetNodeFacets',
   flagUseNewObserveUIs = 'flagUseNewObserveUIs',
   flagMarketplace = 'flagMarketplace',
   flagAssetGraphGroupsPerCodeLocation = 'flagAssetGraphGroupsPerCodeLocation',

js_modules/dagster-ui/packages/ui-core/src/app/useVisibleFeatureFlagRows.oss.tsx

@@ -11,10 +11,6 @@ export const useVisibleFeatureFlagRows = (): FeatureFlagRow[] => [
     key: 'Display resources in navigation sidebar',
     flagType: FeatureFlag.flagSidebarResources,
   },
-  {
-    key: 'Display faceted asset graph nodes',
-    flagType: FeatureFlag.flagAssetNodeFacets,
-  },
   {
     key: 'Display integrations marketplace',
     flagType: FeatureFlag.flagMarketplace,

js_modules/dagster-ui/packages/ui-core/src/asset-graph/AssetGraphExplorer.tsx

@@ -26,7 +26,6 @@ import {AssetEdges} from './AssetEdges';
 import {AssetGraphBackgroundContextMenu} from './AssetGraphBackgroundContextMenu';
 import {AssetGraphJobSidebar} from './AssetGraphJobSidebar';
 import {AssetNode, AssetNodeContextMenuWrapper, AssetNodeMinimal} from './AssetNode';
-import {AssetNode2025} from './AssetNode2025';
 import {AssetNodeFacetSettingsButton} from './AssetNodeFacetSettingsButton';
 import {useSavedAssetNodeFacets} from './AssetNodeFacets';
 import {AssetNodeMenuProps} from './AssetNodeMenu';
@@ -79,11 +78,8 @@ import {LoadingSpinner} from '../ui/Loading';
 import {isIframe} from '../util/isIframe';
 import {AssetGraphExplorerSidebar} from './sidebar/Sidebar';
 import {AssetGraphQueryItem} from './types';
-import {WorkspaceAssetFragment} from '../workspace/WorkspaceContext/types/WorkspaceQueries.types';
 import {buildRepoPathForHuman} from '../workspace/buildRepoAddress';
 
-type AssetNode = WorkspaceAssetFragment;
-
 type Props = {
   options: GraphExplorerOptions;
   setOptions?: (options: GraphExplorerOptions) => void;
@@ -196,7 +192,7 @@ const AssetGraphExplorerWithData = ({
   const [direction, setDirection] = useLayoutDirectionState();
   const [facets, setFacets] = useSavedAssetNodeFacets();
 
-  const {flagAssetNodeFacets, flagAssetGraphGroupsPerCodeLocation} = useFeatureFlags();
+  const {flagAssetGraphGroupsPerCodeLocation} = useFeatureFlags();
 
   const [expandedGroups, setExpandedGroups] = useQueryAndLocalStoragePersistedState<string[]>({
     localStorageKey: `asset-graph-open-graph-nodes-${viewType}-${explorerPath.pipelineName}`,
@@ -222,9 +218,9 @@ const AssetGraphExplorerWithData = ({
       () => ({
         direction,
         flagAssetGraphGroupsPerCodeLocation,
-        facets: flagAssetNodeFacets ? Array.from(facets) : false,
+        facets: Array.from(facets),
       }),
-      [direction, facets, flagAssetGraphGroupsPerCodeLocation, flagAssetNodeFacets],
+      [direction, facets, flagAssetGraphGroupsPerCodeLocation],
     ),
     dataLoading,
   );
@@ -492,9 +488,7 @@ const AssetGraphExplorerWithData = ({
             hideEdgesToNodesOutsideQuery={fetchOptions.hideEdgesToNodesOutsideQuery}
             setHideEdgesToNodesOutsideQuery={setHideEdgesToNodesOutsideQuery}
           />
-          {flagAssetNodeFacets ? (
-            <AssetNodeFacetSettingsButton value={facets} onChange={setFacets} />
-          ) : undefined}
+          <AssetNodeFacetSettingsButton value={facets} onChange={setFacets} />
         </>
       }
       onClick={onClickBackground}
@@ -638,31 +632,23 @@ const AssetGraphExplorerWithData = ({
                 >
                   {!graphNode ? (
                     <AssetNodeLink assetKey={{path}} />
-                  ) : scale < MINIMAL_SCALE || (flagAssetNodeFacets && facets.size === 0) ? (
+                  ) : scale < MINIMAL_SCALE || facets.size === 0 ? (
                     <AssetNodeContextMenuWrapper {...contextMenuProps}>
                       <AssetNodeMinimal
-                        facets={flagAssetNodeFacets ? facets : null}
+                        facets={facets}
                         definition={graphNode.definition}
                         selected={selectedGraphNodes.includes(graphNode)}
                         height={bounds.height}
                       />
                     </AssetNodeContextMenuWrapper>
                   ) : (
                     <AssetNodeContextMenuWrapper {...contextMenuProps}>
-                      {flagAssetNodeFacets ? (
-                        <AssetNode2025
-                          facets={facets}
-                          definition={graphNode.definition}
-                          selected={selectedGraphNodes.includes(graphNode)}
-                          onChangeAssetSelection={onChangeAssetSelection}
-                        />
-                      ) : (
-                        <AssetNode
-                          definition={graphNode.definition}
-                          selected={selectedGraphNodes.includes(graphNode)}
-                          onChangeAssetSelection={onChangeAssetSelection}
-                        />
-                      )}
+                      <AssetNode
+                        facets={facets}
+                        definition={graphNode.definition}
+                        selected={selectedGraphNodes.includes(graphNode)}
+                        onChangeAssetSelection={onChangeAssetSelection}
+                      />
                     </AssetNodeContextMenuWrapper>
                   )}
                 </foreignObject>