Skip to content

Commit 407239d

Browse files
authored
[core-api][experimental] InputDefinition (#26683)
## Summary & Motivation decision: experimental params -> superseded reason: InputDefinition is a very old API that does not really exist in modern-day dagster. explicitly categorizing params for such an old API as experimental seems wasteful, so I just marked the entire class as superseded docs exist: n/a ## How I Tested These Changes ## Changelog > Insert changelog entry or delete this section.
1 parent d009560 commit 407239d

File tree

6 files changed

+12
-13
lines changed

6 files changed

+12
-13
lines changed

python_modules/dagster/dagster/_core/definitions/asset_check_factories/freshness_checks/last_update.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
from typing import Any, Dict, Iterable, Optional, Sequence, Union, cast
33

44
from dagster import _check as check
5-
from dagster._annotations import experimental
5+
from dagster._annotations import beta
66
from dagster._core.definitions.asset_check_factories.utils import (
77
DEADLINE_CRON_PARAM_KEY,
88
DEFAULT_FRESHNESS_SEVERITY,
@@ -40,7 +40,7 @@
4040
)
4141

4242

43-
@experimental
43+
@beta
4444
def build_last_update_freshness_checks(
4545
*,
4646
assets: Sequence[Union[CoercibleToAssetKey, AssetsDefinition, SourceAsset]],

python_modules/dagster/dagster/_core/definitions/asset_check_factories/freshness_checks/sensor.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
from typing import Iterator, Optional, Sequence, Tuple, Union, cast
33

44
from dagster import _check as check
5-
from dagster._annotations import experimental
5+
from dagster._annotations import beta
66
from dagster._core.definitions.asset_check_factories.utils import (
77
FRESH_UNTIL_METADATA_KEY,
88
ensure_no_duplicate_asset_checks,
@@ -33,7 +33,7 @@
3333
"""
3434

3535

36-
@experimental
36+
@beta
3737
def build_sensor_for_freshness_checks(
3838
*,
3939
freshness_checks: Sequence[AssetChecksDefinition],

python_modules/dagster/dagster/_core/definitions/asset_check_factories/freshness_checks/time_partition.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
from typing import Any, Dict, Iterable, Sequence, Union
22

33
from dagster import _check as check
4-
from dagster._annotations import experimental
4+
from dagster._annotations import beta
55
from dagster._core.definitions.asset_check_factories.utils import (
66
DEADLINE_CRON_PARAM_KEY,
77
DEFAULT_FRESHNESS_SEVERITY,
@@ -37,7 +37,7 @@
3737
)
3838

3939

40-
@experimental
40+
@beta
4141
def build_time_partition_freshness_checks(
4242
*,
4343
assets: Sequence[Union[SourceAsset, CoercibleToAssetKey, AssetsDefinition]],

python_modules/dagster/dagster/_core/definitions/asset_check_factories/metadata_bounds_checks.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
from typing import Optional, Sequence, Tuple, Union, cast
33

44
import dagster._check as check
5-
from dagster._annotations import experimental
5+
from dagster._annotations import beta
66
from dagster._core.definitions.asset_check_factories.utils import (
77
assets_to_keys,
88
build_multi_asset_check,
@@ -21,7 +21,7 @@
2121
from dagster._core.instance import DagsterInstance
2222

2323

24-
@experimental
24+
@beta
2525
def build_metadata_bounds_checks(
2626
*,
2727
assets: Sequence[Union[CoercibleToAssetKey, AssetsDefinition, SourceAsset]],

python_modules/dagster/dagster/_core/definitions/asset_check_factories/schema_change_checks.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
from pydantic import BaseModel
44

5-
from dagster._annotations import experimental
5+
from dagster._annotations import beta
66
from dagster._core.definitions.asset_check_factories.utils import build_multi_asset_check
77
from dagster._core.definitions.asset_check_spec import (
88
AssetCheckKey,
@@ -17,7 +17,7 @@
1717
from dagster._core.instance import DagsterInstance
1818

1919

20-
@experimental
20+
@beta
2121
def build_column_schema_change_checks(
2222
*,
2323
assets: Sequence[Union[CoercibleToAssetKey, AssetsDefinition, SourceAsset]],

python_modules/dagster/dagster/_core/definitions/input.py

+2-3
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
)
1515

1616
import dagster._check as check
17-
from dagster._annotations import PublicAttr, deprecated_param, experimental_param
17+
from dagster._annotations import PublicAttr, deprecated_param, superseded
1818
from dagster._core.definitions.events import AssetKey
1919
from dagster._core.definitions.inference import InferredInputProps
2020
from dagster._core.definitions.metadata import (
@@ -59,8 +59,7 @@ def _check_default_value(input_name: str, dagster_type: DagsterType, default_val
5959
return default_value # type: ignore # (pyright bug)
6060

6161

62-
@experimental_param(param="asset_key")
63-
@experimental_param(param="asset_partitions")
62+
@superseded(additional_warn_text="Use `In` instead", emit_runtime_warning=False)
6463
class InputDefinition:
6564
"""Defines an argument to an op's compute function.
6665

0 commit comments

Comments
 (0)