Scope serverless deploy registry URL to the target deployment (#25879)

## Summary & Motivation

Target the deployment when pushing images to harbor else it will fail on
non-prod deployments

Internal-RevId: 4529fb377b0cbe7e6e5cd3ca50f673cc2ba6bef4

Author: sndagster

python_modules/libraries/dagster-cloud-cli/dagster_cloud_cli/commands/ci/__init__.py

@@ -832,7 +832,7 @@ def _build_docker(
 ) -> state.DockerBuildOutput:
     name = location_state.location_name
     docker_utils.verify_docker()
-    registry_info = utils.get_registry_info(url)
+    registry_info = utils.get_registry_info(url, location_state.deployment_name)
     repo_location = name if registry_info.get("is_harbor") else None
 
     docker_image_tag = docker_utils.default_image_tag(

python_modules/libraries/dagster-cloud-cli/dagster_cloud_cli/commands/ci/utils.py

@@ -17,6 +17,6 @@ def client_from_env(url: str, deployment: str | None = None):
         yield client
 
 
-def get_registry_info(url: str) -> dict[str, Any]:
-    with client_from_env(url) as client:
+def get_registry_info(url: str, deployment: str) -> dict[str, Any]:
+    with client_from_env(url, deployment=deployment) as client:
         return gql.get_ecr_info(client)

python_modules/libraries/dagster-cloud-cli/dagster_cloud_cli_tests/test_ci_commands.py

@@ -407,7 +407,7 @@ def test_ci_deploy_docker(
     mocker, monkeypatch, deployment_name: str, initialized_runner: CliRunner
 ) -> None:
     monkeypatch.setenv("DAGSTER_CLOUD_API_TOKEN", "fake-token")
-    mocker.patch(
+    mock_get_registry_info = mocker.patch(
         "dagster_cloud_cli.commands.ci.utils.get_registry_info",
         return_value={"registry_url": "example.com/image-registry"},
     )
@@ -423,6 +423,12 @@ def test_ci_deploy_docker(
     initialized_runner.invoke(app, ["ci", "locations-deselect", "a", "d"])
     result = initialized_runner.invoke(app, ["ci", "build"])
     assert not result.exit_code, result.output
+
+    # registry info must be scoped to the target deployment (per-deployment Harbor tenant)
+    assert mock_get_registry_info.call_args_list
+    for call_args in mock_get_registry_info.call_args_list:
+        assert call_args.args[1] == deployment_name
+
     result = initialized_runner.invoke(app, ["ci", "deploy"])
     assert not result.exit_code, result.output