Commit 4fb0017
[dagster-dbt] Gracefully skip insights on unsupported adapters in with_insights (#25440)
## Summary & Motivation
Matches the behavior of `.with_insights()` chained method with the older `dbt_with_snowflake_insights()` method for generating dbt snowflake insights, where calling the method on an adapter that doesn't support cost insights raises a warning instead of an error (since there are cases, like with out demo, where you want to use different database engines without changing the code).
## Test Plan
BK
## Changelog
- [dagster-dbt] using the `.with_insights()` method now sends a warning instead of an error if you are not using a supported adapter
Internal-RevId: 51a35ce08ae3101758315258f3ff1c5badc482801 parent cd7ed61 commit 4fb0017
2 files changed
Lines changed: 24 additions & 11 deletions
File tree
- python_modules/libraries/dagster-dbt
- dagster_dbt_tests/core
- dagster_dbt/core
Lines changed: 11 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
326 | 326 | | |
327 | 327 | | |
328 | 328 | | |
329 | | - | |
| 329 | + | |
| 330 | + | |
| 331 | + | |
330 | 332 | | |
331 | 333 | | |
332 | 334 | | |
| |||
393 | 395 | | |
394 | 396 | | |
395 | 397 | | |
396 | | - | |
397 | | - | |
| 398 | + | |
| 399 | + | |
| 400 | + | |
| 401 | + | |
| 402 | + | |
| 403 | + | |
| 404 | + | |
| 405 | + | |
398 | 406 | | |
Lines changed: 13 additions & 8 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
13 | | - | |
14 | 13 | | |
15 | 14 | | |
16 | 15 | | |
| |||
138 | 137 | | |
139 | 138 | | |
140 | 139 | | |
141 | | - | |
| 140 | + | |
142 | 141 | | |
143 | 142 | | |
144 | 143 | | |
| 144 | + | |
| 145 | + | |
145 | 146 | | |
146 | 147 | | |
147 | 148 | | |
148 | 149 | | |
149 | | - | |
150 | | - | |
151 | | - | |
152 | | - | |
153 | | - | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
154 | 154 | | |
155 | | - | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
156 | 161 | | |
157 | 162 | | |
158 | 163 | | |
| |||
0 commit comments