@@ -18,6 +18,7 @@ import {useMemo} from 'react';
1818import { RunList , TargetedRunList } from './InstigationTick' ;
1919import { HISTORY_TICK_FRAGMENT } from './InstigationUtils' ;
2020import { TickMaterializationsTable } from './TickMaterializationsTable' ;
21+ import { getTickResultType } from './util' ;
2122import { gql , useQuery } from '../apollo-client' ;
2223import { HistoryTickFragment } from './types/InstigationUtils.types' ;
2324import { SelectedTickQuery , SelectedTickQueryVariables } from './types/TickDetailsDialog.types' ;
@@ -46,24 +47,14 @@ interface DialogProps extends InnerProps {
4647 isOpen : boolean ;
4748}
4849
49- export const TickDetailsDialog = ( {
50- tickId,
51- tickResultType,
52- isOpen,
53- instigationSelector,
54- onClose,
55- } : DialogProps ) => {
50+ export const TickDetailsDialog = ( { tickId, isOpen, instigationSelector, onClose} : DialogProps ) => {
5651 return (
5752 < Dialog
5853 isOpen = { isOpen }
5954 onClose = { onClose }
6055 style = { { width : '80vw' , maxWidth : '1200px' , minWidth : '600px' } }
6156 >
62- < TickDetailsDialogImpl
63- tickId = { tickId }
64- tickResultType = { tickResultType }
65- instigationSelector = { instigationSelector }
66- />
57+ < TickDetailsDialogImpl tickId = { tickId } instigationSelector = { instigationSelector } />
6758 < DialogFooter topBorder >
6859 < Button onClick = { onClose } > Close</ Button >
6960 </ DialogFooter >
@@ -73,11 +64,10 @@ export const TickDetailsDialog = ({
7364
7465interface InnerProps {
7566 tickId : string | undefined ;
76- tickResultType : TickResultType ;
7767 instigationSelector : InstigationSelector ;
7868}
7969
80- const TickDetailsDialogImpl = ( { tickId, tickResultType , instigationSelector} : InnerProps ) => {
70+ const TickDetailsDialogImpl = ( { tickId, instigationSelector} : InnerProps ) => {
8171 const { data, loading} = useQuery < SelectedTickQuery , SelectedTickQueryVariables > (
8272 JOB_SELECTED_TICK_QUERY ,
8373 {
@@ -131,6 +121,8 @@ const TickDetailsDialogImpl = ({tickId, tickResultType, instigationSelector}: In
131121 ) ;
132122 }
133123
124+ const resultType = getTickResultType ( tick ) ;
125+
134126 return (
135127 < >
136128 < DialogHeader
@@ -145,10 +137,10 @@ const TickDetailsDialogImpl = ({tickId, tickResultType, instigationSelector}: In
145137 }
146138 />
147139 < Box padding = { { vertical : 12 , horizontal : 24 } } border = "bottom" >
148- < TickDetailSummary tick = { tick } tickResultType = { tickResultType } />
140+ < TickDetailSummary tick = { tick } tickResultType = { resultType } />
149141 </ Box >
150- { tickResultType === 'materializations' ? < TickMaterializationsTable tick = { tick } /> : null }
151- { tickResultType === 'runs' ? (
142+ { resultType === 'materializations' ? < TickMaterializationsTable tick = { tick } /> : null }
143+ { resultType === 'runs' ? (
152144 < div style = { { height : '500px' , overflowY : 'auto' } } >
153145 { tick . runIds . length ? (
154146 < >
0 commit comments