Skip to content

Commit 596de53

Browse files
authored
Remove libraries folder from scaffolded workspace (#29158)
Summary: As title. ## How I Tested These Changes BK
1 parent be222b9 commit 596de53

File tree

7 files changed

+4
-9
lines changed

7 files changed

+4
-9
lines changed

examples/docs_snippets/docs_snippets/guides/dg/workspace/2-tree.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ cd dagster-workspace && tree
22

33
.
44
├── dg.toml
5-
├── libraries
65
└── projects
76
└── project-1
87
├── pyproject.toml

python_modules/libraries/dagster-dg/dagster_dg/cli/init.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -95,8 +95,6 @@ def init_command(
9595
├── <workspace_name>
9696
│ ├── projects
9797
| | └── <Dagster projects go here>
98-
| ├── libraries
99-
| | └── <Shared packages go here>
10098
│ └── pyproject.toml
10199
102100
"""

python_modules/libraries/dagster-dg/dagster_dg/cli/scaffold.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -179,8 +179,6 @@ def scaffold_workspace_command(
179179
├── <workspace_name>
180180
│ ├── projects
181181
| | └── <Dagster projects go here>
182-
| ├── libraries
183-
| | └── <Shared packages go here>
184182
│ └── pyproject.toml
185183
186184
"""

python_modules/libraries/dagster-dg/dagster_dg/templates/WORKSPACE_NAME_PLACEHOLDER/libraries/.gitkeep

Whitespace-only changes.

python_modules/libraries/dagster-dg/dagster_dg_tests/cli_tests/test_init_command.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ def test_init_success_workspace(
9999
assert Path("dagster-workspace").exists()
100100
assert Path("dagster-workspace/dg.toml").exists()
101101
assert Path("dagster-workspace/projects").exists()
102-
assert Path("dagster-workspace/libraries").exists()
102+
assert not Path("dagster-workspace/libraries").exists()
103103
assert Path("dagster-workspace/projects/helloworld").exists()
104104
assert Path("dagster-workspace/projects/helloworld/src/helloworld").exists()
105105
assert Path("dagster-workspace/projects/helloworld/pyproject.toml").exists()

python_modules/libraries/dagster-dg/dagster_dg_tests/cli_tests/test_scaffold_commands.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ def test_scaffold_workspace_command_success(monkeypatch) -> None:
4747
assert Path("dagster-workspace").exists()
4848
assert Path("dagster-workspace/dg.toml").exists()
4949
assert Path("dagster-workspace/projects").exists()
50-
assert Path("dagster-workspace/libraries").exists()
50+
assert not Path("dagster-workspace/libraries").exists()
5151

5252
result = runner.invoke("scaffold", "workspace")
5353
assert_runner_result(result, exit_0=False)
@@ -61,7 +61,7 @@ def test_scaffold_workspace_command_name_override_success(monkeypatch) -> None:
6161
assert Path("my-workspace").exists()
6262
assert Path("my-workspace/dg.toml").exists()
6363
assert Path("my-workspace/projects").exists()
64-
assert Path("my-workspace/libraries").exists()
64+
assert not Path("my-workspace/libraries").exists()
6565

6666
result = runner.invoke("scaffold", "workspace", "my-workspace")
6767
assert_runner_result(result, exit_0=False)

python_modules/libraries/dagster-dg/dagster_dg_tests/test_context.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ def test_context_in_workspace(config_file: ConfigFileType):
3939
isolated_example_workspace(runner, workspace_config_file_type=config_file),
4040
):
4141
# go into a subdirectory to make sure root resolution works
42-
path_arg = Path.cwd() / "libraries"
42+
path_arg = Path.cwd() / "projects"
4343

4444
context = DgContext.for_workspace_environment(path_arg, {})
4545
assert context.root_path == Path.cwd()

0 commit comments

Comments
 (0)