Skip to content

Commit 6c7e648

Browse files
authored
[core-api][experimental] exclude_subruns (#26687)
## Summary & Motivation decision: experimental -> public reason: we rely on this functionality fairly heavily internally, making it unlikely that we could change it even if we wanted to (beyond a name change, which is easy enough to do in a non-breaking way in the future) docs exist: yes (api only, which is ok) ## How I Tested These Changes ## Changelog > Insert changelog entry or delete this section.
1 parent 734f308 commit 6c7e648

File tree

14 files changed

+17
-36
lines changed

14 files changed

+17
-36
lines changed

python_modules/dagster/dagster/_core/definitions/asset_check_factories/freshness_checks/last_update.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
from typing import Any, Dict, Iterable, Optional, Sequence, Union, cast
33

44
from dagster import _check as check
5-
from dagster._annotations import experimental
5+
from dagster._annotations import beta
66
from dagster._core.definitions.asset_check_factories.utils import (
77
DEADLINE_CRON_PARAM_KEY,
88
DEFAULT_FRESHNESS_SEVERITY,
@@ -40,7 +40,7 @@
4040
)
4141

4242

43-
@experimental
43+
@beta
4444
def build_last_update_freshness_checks(
4545
*,
4646
assets: Sequence[Union[CoercibleToAssetKey, AssetsDefinition, SourceAsset]],

python_modules/dagster/dagster/_core/definitions/asset_check_factories/freshness_checks/sensor.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
from typing import Iterator, Optional, Sequence, Tuple, Union, cast
33

44
from dagster import _check as check
5-
from dagster._annotations import experimental
5+
from dagster._annotations import beta
66
from dagster._core.definitions.asset_check_factories.utils import (
77
FRESH_UNTIL_METADATA_KEY,
88
ensure_no_duplicate_asset_checks,
@@ -33,7 +33,7 @@
3333
"""
3434

3535

36-
@experimental
36+
@beta
3737
def build_sensor_for_freshness_checks(
3838
*,
3939
freshness_checks: Sequence[AssetChecksDefinition],

python_modules/dagster/dagster/_core/definitions/asset_check_factories/freshness_checks/time_partition.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
from typing import Any, Dict, Iterable, Sequence, Union
22

33
from dagster import _check as check
4-
from dagster._annotations import experimental
4+
from dagster._annotations import beta
55
from dagster._core.definitions.asset_check_factories.utils import (
66
DEADLINE_CRON_PARAM_KEY,
77
DEFAULT_FRESHNESS_SEVERITY,
@@ -37,7 +37,7 @@
3737
)
3838

3939

40-
@experimental
40+
@beta
4141
def build_time_partition_freshness_checks(
4242
*,
4343
assets: Sequence[Union[SourceAsset, CoercibleToAssetKey, AssetsDefinition]],

python_modules/dagster/dagster/_core/definitions/asset_check_factories/metadata_bounds_checks.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
from typing import Optional, Sequence, Tuple, Union, cast
33

44
import dagster._check as check
5-
from dagster._annotations import experimental
5+
from dagster._annotations import beta
66
from dagster._core.definitions.asset_check_factories.utils import (
77
assets_to_keys,
88
build_multi_asset_check,
@@ -21,7 +21,7 @@
2121
from dagster._core.instance import DagsterInstance
2222

2323

24-
@experimental
24+
@beta
2525
def build_metadata_bounds_checks(
2626
*,
2727
assets: Sequence[Union[CoercibleToAssetKey, AssetsDefinition, SourceAsset]],

python_modules/dagster/dagster/_core/definitions/asset_check_factories/schema_change_checks.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
from pydantic import BaseModel
44

5-
from dagster._annotations import experimental
5+
from dagster._annotations import beta
66
from dagster._core.definitions.asset_check_factories.utils import build_multi_asset_check
77
from dagster._core.definitions.asset_check_spec import (
88
AssetCheckKey,
@@ -17,7 +17,7 @@
1717
from dagster._core.instance import DagsterInstance
1818

1919

20-
@experimental
20+
@beta
2121
def build_column_schema_change_checks(
2222
*,
2323
assets: Sequence[Union[CoercibleToAssetKey, AssetsDefinition, SourceAsset]],

python_modules/dagster/dagster/_core/definitions/asset_out.py

+1-8
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,7 @@
11
from typing import Any, Mapping, Optional, Sequence, Type, Union
22

33
import dagster._check as check
4-
from dagster._annotations import (
5-
experimental_param,
6-
hidden_param,
7-
only_allow_hidden_params_in_kwargs,
8-
public,
9-
)
4+
from dagster._annotations import hidden_param, only_allow_hidden_params_in_kwargs, public
105
from dagster._core.definitions.asset_dep import AssetDep
116
from dagster._core.definitions.asset_spec import AssetSpec
127
from dagster._core.definitions.auto_materialize_policy import AutoMaterializePolicy
@@ -35,8 +30,6 @@
3530
EMPTY_ASSET_KEY_SENTINEL = AssetKey([])
3631

3732

38-
@experimental_param(param="owners")
39-
@experimental_param(param="tags")
4033
@hidden_param(
4134
param="freshness_policy",
4235
breaking_version="1.10.0",

python_modules/dagster/dagster/_core/definitions/asset_spec.py

-2
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818
import dagster._check as check
1919
from dagster._annotations import (
2020
PublicAttr,
21-
experimental_param,
2221
hidden_param,
2322
only_allow_hidden_params_in_kwargs,
2423
public,
@@ -96,7 +95,6 @@ def validate_kind_tags(kinds: Optional[AbstractSet[str]]) -> None:
9695
raise DagsterInvalidDefinitionError("Assets can have at most three kinds currently.")
9796

9897

99-
@experimental_param(param="owners")
10098
@hidden_param(
10199
param="freshness_policy",
102100
breaking_version="1.10.0",

python_modules/dagster/dagster/_core/definitions/assets.py

-1
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,6 @@ class AssetsDefinition(ResourceAddable, IHasInternalInit):
119119
_specs_by_key: Mapping[AssetKey, AssetSpec]
120120
_computation: Optional[AssetGraphComputation]
121121

122-
@experimental_param(param="specs")
123122
@experimental_param(param="execution_type")
124123
def __init__(
125124
self,

python_modules/dagster/dagster/_core/definitions/decorators/asset_decorator.py

-2
Original file line numberDiff line numberDiff line change
@@ -134,7 +134,6 @@ def _validate_hidden_non_argument_dep_param(
134134
@experimental_param(param="resource_defs")
135135
@experimental_param(param="io_manager_def")
136136
@experimental_param(param="backfill_policy")
137-
@experimental_param(param="owners")
138137
@hidden_param(
139138
param="non_argument_deps",
140139
breaking_version="2.0.0",
@@ -736,7 +735,6 @@ def graph_asset(
736735
) -> Callable[[Callable[..., Any]], AssetsDefinition]: ...
737736

738737

739-
@experimental_param(param="owners")
740738
@hidden_param(
741739
param="freshness_policy",
742740
breaking_version="1.10.0",

python_modules/dagster/dagster/_core/definitions/external_asset.py

+1-2
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
from typing import List, Sequence
22

33
from dagster import _check as check
4-
from dagster._annotations import deprecated, experimental
4+
from dagster._annotations import deprecated
55
from dagster._core.definitions.asset_spec import (
66
SYSTEM_METADATA_KEY_AUTO_OBSERVE_INTERVAL_MINUTES,
77
SYSTEM_METADATA_KEY_IO_MANAGER_KEY,
@@ -23,7 +23,6 @@ def external_asset_from_spec(spec: AssetSpec) -> AssetsDefinition:
2323

2424

2525
@deprecated(breaking_version="1.9.0", additional_warn_text="Directly use the AssetSpecs instead.")
26-
@experimental
2726
def external_assets_from_specs(specs: Sequence[AssetSpec]) -> List[AssetsDefinition]:
2827
"""Create an external assets definition from a sequence of asset specs.
2928

python_modules/dagster/dagster/_core/definitions/input.py

+2-3
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
)
1515

1616
import dagster._check as check
17-
from dagster._annotations import PublicAttr, deprecated_param, experimental_param
17+
from dagster._annotations import PublicAttr, deprecated_param, superseded
1818
from dagster._core.definitions.events import AssetKey
1919
from dagster._core.definitions.inference import InferredInputProps
2020
from dagster._core.definitions.metadata import (
@@ -59,8 +59,7 @@ def _check_default_value(input_name: str, dagster_type: DagsterType, default_val
5959
return default_value # type: ignore # (pyright bug)
6060

6161

62-
@experimental_param(param="asset_key")
63-
@experimental_param(param="asset_partitions")
62+
@superseded(additional_warn_text="Use `In` instead", emit_runtime_warning=False)
6463
class InputDefinition:
6564
"""Defines an argument to an op's compute function.
6665

python_modules/dagster/dagster/_core/definitions/run_request.py

+1-4
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
)
1717

1818
import dagster._check as check
19-
from dagster._annotations import PublicAttr, experimental_param
19+
from dagster._annotations import PublicAttr
2020
from dagster._core.definitions.asset_check_evaluation import AssetCheckEvaluation
2121
from dagster._core.definitions.asset_check_spec import AssetCheckKey
2222
from dagster._core.definitions.asset_graph_subset import AssetGraphSubset
@@ -354,9 +354,6 @@ def __new__(
354354
)
355355

356356

357-
@experimental_param(
358-
param="asset_events", additional_warn_text="Runless asset events are experimental"
359-
)
360357
class SensorResult(
361358
NamedTuple(
362359
"_SensorResult",

python_modules/dagster/dagster/_core/instance/__init__.py

+1-2
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@
3232
from typing_extensions import Protocol, Self, TypeAlias, TypeVar, runtime_checkable
3333

3434
import dagster._check as check
35-
from dagster._annotations import deprecated, experimental, public
35+
from dagster._annotations import deprecated, public
3636
from dagster._core.definitions.asset_check_evaluation import (
3737
AssetCheckEvaluation,
3838
AssetCheckEvaluationPlanned,
@@ -3261,7 +3261,6 @@ def get_latest_materialization_code_versions(
32613261

32623262
return result
32633263

3264-
@experimental
32653264
@public
32663265
def report_runless_asset_event(
32673266
self,

python_modules/dagster/dagster/_core/storage/dagster_run.py

+1-2
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
from typing_extensions import Self
2020

2121
import dagster._check as check
22-
from dagster._annotations import PublicAttr, experimental_param, public
22+
from dagster._annotations import PublicAttr, public
2323
from dagster._core.definitions.asset_check_spec import AssetCheckKey
2424
from dagster._core.definitions.events import AssetKey
2525
from dagster._core.loader import LoadableBy, LoadingContext
@@ -615,7 +615,6 @@ class RunsFilter(IHaveNew):
615615
created_before: Optional[datetime]
616616
exclude_subruns: Optional[bool]
617617

618-
@experimental_param(param="exclude_subruns")
619618
def __new__(
620619
cls,
621620
run_ids: Optional[Sequence[str]] = None,

0 commit comments

Comments
 (0)