Commit 7a8d2fa
committed
fix: remove duplicate partition_key defs, fix breaking_version to 2.0
- Remove the asset-partition-derived `partition_key` property that was
silently overwriting the existing run-level `partition_key` property
(`self._partition_key`) in both InputContext and OutputContext.
The `asset_partition_key` → `partition_key` rename cannot be done
until the run-level `partition_key` property is itself deprecated;
that should be a separate PR.
- Remove the now-unreachable `@deprecated asset_partition_key` wrappers
that delegated to the overwritten property.
- Fix `breaking_version="2.0.0"` → `"2.0"` across all new deprecation
annotations to match every other deprecation in the execution/context
package.
Addresses Greptile review feedback on PR #33896.1 parent 608fc7d commit 7a8d2fa
2 files changed
Lines changed: 8 additions & 73 deletions
Lines changed: 4 additions & 33 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
183 | 183 | | |
184 | 184 | | |
185 | 185 | | |
186 | | - | |
| 186 | + | |
187 | 187 | | |
188 | 188 | | |
189 | 189 | | |
| |||
336 | 336 | | |
337 | 337 | | |
338 | 338 | | |
339 | | - | |
340 | | - | |
341 | | - | |
342 | | - | |
343 | | - | |
344 | | - | |
345 | | - | |
346 | | - | |
347 | | - | |
348 | | - | |
349 | | - | |
350 | | - | |
351 | | - | |
352 | | - | |
353 | | - | |
354 | | - | |
355 | | - | |
356 | | - | |
357 | | - | |
358 | | - | |
359 | | - | |
360 | | - | |
361 | | - | |
362 | | - | |
363 | | - | |
364 | | - | |
365 | | - | |
366 | | - | |
367 | | - | |
368 | 339 | | |
369 | 340 | | |
370 | 341 | | |
| |||
391 | 362 | | |
392 | 363 | | |
393 | 364 | | |
394 | | - | |
| 365 | + | |
395 | 366 | | |
396 | 367 | | |
397 | 368 | | |
| |||
412 | 383 | | |
413 | 384 | | |
414 | 385 | | |
415 | | - | |
| 386 | + | |
416 | 387 | | |
417 | 388 | | |
418 | 389 | | |
| |||
451 | 422 | | |
452 | 423 | | |
453 | 424 | | |
454 | | - | |
| 425 | + | |
455 | 426 | | |
456 | 427 | | |
457 | 428 | | |
| |||
Lines changed: 4 additions & 40 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
237 | 237 | | |
238 | 238 | | |
239 | 239 | | |
240 | | - | |
| 240 | + | |
241 | 241 | | |
242 | 242 | | |
243 | 243 | | |
| |||
464 | 464 | | |
465 | 465 | | |
466 | 466 | | |
467 | | - | |
468 | | - | |
469 | | - | |
470 | | - | |
471 | | - | |
472 | | - | |
473 | | - | |
474 | | - | |
475 | | - | |
476 | | - | |
477 | | - | |
478 | | - | |
479 | | - | |
480 | | - | |
481 | | - | |
482 | | - | |
483 | | - | |
484 | | - | |
485 | | - | |
486 | | - | |
487 | | - | |
488 | | - | |
489 | | - | |
490 | | - | |
491 | | - | |
492 | | - | |
493 | | - | |
494 | | - | |
495 | | - | |
496 | | - | |
497 | | - | |
498 | | - | |
499 | | - | |
500 | | - | |
501 | | - | |
502 | | - | |
503 | 467 | | |
504 | 468 | | |
505 | 469 | | |
| |||
532 | 496 | | |
533 | 497 | | |
534 | 498 | | |
535 | | - | |
| 499 | + | |
536 | 500 | | |
537 | 501 | | |
538 | 502 | | |
| |||
559 | 523 | | |
560 | 524 | | |
561 | 525 | | |
562 | | - | |
| 526 | + | |
563 | 527 | | |
564 | 528 | | |
565 | 529 | | |
| |||
604 | 568 | | |
605 | 569 | | |
606 | 570 | | |
607 | | - | |
| 571 | + | |
608 | 572 | | |
609 | 573 | | |
610 | 574 | | |
| |||
0 commit comments