Skip to content

Commit 9c7275e

Browse files
vincere-moriclaude
andcommitted
test(helm): add zero-value and large-int coverage for db flag rendering
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
1 parent 27b8d54 commit 9c7275e

1 file changed

Lines changed: 35 additions & 0 deletions

File tree

helm/dagster/schema/schema_tests/test_dagit.py

Lines changed: 35 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -312,6 +312,41 @@ def test_webserver_db_pool_max_overflow(deployment_template: HelmTemplate):
312312
assert f"--db-pool-max-overflow {pool_max_overflow_s}" in command
313313

314314

315+
def test_webserver_db_flags_zero_values(deployment_template: HelmTemplate):
316+
helm_values = DagsterHelmValues.construct(
317+
dagsterWebserver=Webserver.construct(
318+
dbStatementTimeout=0,
319+
dbPoolRecycle=0,
320+
dbPoolMaxOverflow=0,
321+
)
322+
)
323+
324+
webserver_deployments = deployment_template.render(helm_values)
325+
command = " ".join(webserver_deployments[0].spec.template.spec.containers[0].command)
326+
327+
assert "--db-statement-timeout 0" in command
328+
assert "--db-pool-recycle 0" in command
329+
assert "--db-pool-max-overflow 0" in command
330+
331+
332+
def test_webserver_db_flags_large_values(deployment_template: HelmTemplate):
333+
large_value = 2147483647
334+
helm_values = DagsterHelmValues.construct(
335+
dagsterWebserver=Webserver.construct(
336+
dbStatementTimeout=large_value,
337+
dbPoolRecycle=large_value,
338+
dbPoolMaxOverflow=large_value,
339+
)
340+
)
341+
342+
webserver_deployments = deployment_template.render(helm_values)
343+
command = " ".join(webserver_deployments[0].spec.template.spec.containers[0].command)
344+
345+
assert f"--db-statement-timeout {large_value}" in command
346+
assert f"--db-pool-recycle {large_value}" in command
347+
assert f"--db-pool-max-overflow {large_value}" in command
348+
349+
315350
def test_webserver_log_level(deployment_template: HelmTemplate):
316351
log_level = "trace"
317352
helm_values = DagsterHelmValues.construct(

0 commit comments

Comments
 (0)