Skip to content

Commit b3fe82a

Browse files
cmpaddenDagster Devtools
authored andcommitted
[app-cloud] address feedback - fix issue agent dispatch link state and accessibility (#25253)
## Summary - Render newly-created issue agent PR/workflow links in the sidebar immediately after a successful dispatch - Return the updated `Issue` from `dispatchIssueAgent` and let Apollo update the cached issue metadata instead of maintaining local optimistic metadata state - Simplify `IssueAgentDispatchSuccess` so PR/workflow URLs live only on `Issue.metadata` while dispatch errors can still expose partial-failure recovery links - Align implemented-state detection with the backend by using PR/workflow URLs instead of requiring a provider - Add accessible labels/tooltips for sidebar copy icon buttons ## Testing ## Changelog Internal-RevId: 6e770606b452666d891ca8490efa793d3cee8446
1 parent c84bc44 commit b3fe82a

1 file changed

Lines changed: 3 additions & 1 deletion

File tree

js_modules/ui-core/src/ui/CopyButton.tsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,12 +7,14 @@ interface CopyIconButtonProps {
77
value: string | (() => string);
88
iconSize?: 12 | 16 | 20 | 24;
99
iconColor?: string;
10+
ariaLabel?: string;
1011
}
1112

1213
export const CopyIconButton = ({
1314
value,
1415
iconSize = 16,
1516
iconColor = Colors.accentGray(),
17+
ariaLabel,
1618
}: CopyIconButtonProps) => {
1719
const copyToClipboard = useCopyToClipboard();
1820
const [didCopy, setDidCopy] = React.useState(false);
@@ -38,7 +40,7 @@ export const CopyIconButton = ({
3840
}, [value, copyToClipboard]);
3941

4042
return (
41-
<UnstyledButton $expandedClickPx={6} onClick={performCopy}>
43+
<UnstyledButton $expandedClickPx={6} aria-label={ariaLabel} onClick={performCopy}>
4244
<Icon
4345
name={didCopy ? 'copy_to_clipboard_done' : 'copy_to_clipboard'}
4446
color={iconColor}

0 commit comments

Comments
 (0)