Commit bf00518
ci(buildkite): migrate dagster-aws, dagster-dask, dagster-azure-live-tests to EKS (#24716)
## Summary & Motivation
Follow-up to #24661. Drops three more OSS test suites off the MEDIUM
(EC2) queue onto `kubernetes-eks`.
The three suites were on MEDIUM with `env_vars=[AWS_*]` or
`env_vars=[TEST_AZURE_*]` configured, which made it look like a
secrets-provisioning blocker. On inspection it isn't:
| Suite | Reality |
|---|---|
| **`dagster-aws`** | `conftest.py` autouse fixture sets fake creds with
`monkeypatch.setenv("AWS_ACCESS_KEY_ID", "test")` etc., tests use
`moto.mock_aws` — no real AWS access. The `env_vars=[AWS_*]` was
vestigial. |
| **`dagster-dask`** | Tests don't import boto3 or touch AWS at all. The
`env_vars=[AWS_*]` was fully vestigial. |
| **`dagster-azure-live-tests`** | `TEST_AZURE_*` keys already live in
the EKS K8s secret `buildkite-dagster-secrets`
(`infra/k8s/buildkite/overlays/buildkite-eks/secrets.yaml:62-67`), which
is auto-mounted on every step pod via `envFrom`
(`command_step_builder.py:582-589`). So the suite's
`env_vars=[TEST_AZURE_*]` just allowlists the names through the
docker→pod boundary, and the actual values reach the test process for
free. |
So there's no secret-provisioning work to do — just dropping the
`queue=BuildkiteQueue.MEDIUM` toggle and cleaning up the dead AWS
`env_vars` lists on `dagster-aws` / `dagster-dask`.
## Changes
-
`dagster-oss/.buildkite/dagster-buildkite/dagster_buildkite/steps/packages.py`
- `dagster-aws`: drop `queue=BuildkiteQueue.MEDIUM` and
`env_vars=[AWS_*]`. PackageSpec is now bare.
- `dagster-dask`: same.
-
`dagster-oss/.buildkite/dagster-buildkite/dagster_buildkite/steps/integration.py`
- `dagster-azure-live-tests`: drop `queue=BuildkiteQueue.MEDIUM`. Keep
the `env_vars=[TEST_AZURE_*]` allowlist (still needed at the docker
boundary).
Starting with default EKS sizing on all three (outer pod 1000m cpu / no
memory request → BestEffort QoS, dind sidecar 2000m / 1Gi req / 2Gi
limit / 10Gi ephemeral storage). The Azure suite runs `just rebuild_ui`
plus a `dagster-webserver` subprocess, which could be RAM-hungry;
flagging that as the likely candidate for a follow-up bump if it OOMs.
## Test Plan
- [ ] CI passes on this PR.
- [ ] On the resulting build, all three step keys (`dagster-aws-*`,
`dagster-dask-*`, `dagster-azure-live-tests-*`) report `agent:
kubernetes-eks` rather than `medium`.
- [ ] The Azure suite isn't selectable from this PR (it has
`skip_if_not_azure_commit`); follow-up: ensure the next
dagster-azure-touching PR exercises it on EKS.
- [ ] Watch the first ~5–10 master builds post-merge. If
`dagster-azure-live-tests` OOMs on the `yarn rebuild_ui` step or the
dagster-webserver subprocess, follow up with
`ResourceRequests(cpu="1000m", memory="1Gi", docker_memory="2Gi",
docker_memory_limit="4Gi")` — same shape as the dagster-mysql bump in
#24661.
## Remaining OSS MEDIUM-queue surface
After this lands, the remaining `queue=BuildkiteQueue.MEDIUM` entries in
the OSS step builders are:
- Test-project-blocked (waiting on the ECR repo policy in #24713 to
apply): `test-project-image` build, `dagster-celery-docker`,
`dagster-docker`
- Airflow / airlift-bound: `dagster-airlift`,
`dagster-airlift/perf-harness`, `dagster-test`
- Compose / multi-container fixtures: `backcompat-test-suite`,
`daemon-test-suite`
- Unexplained: `dagster-graphql`
- Per-factor outliers: `dagster-dg-cli` `slow`, `dagstermill`
`papermill2`
## Changelog
NOCHANGELOG
---------
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Internal-RevId: b557ef90abc6ef78190f1e730f8bee95aa4a58561 parent 6d59727 commit bf00518
4 files changed
Lines changed: 12 additions & 6 deletions
File tree
- .buildkite/dagster-buildkite/dagster_buildkite/steps
- python_modules/libraries/dagster-aws/dagster_aws_tests/pipes_tests
Lines changed: 0 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
171 | 171 | | |
172 | 172 | | |
173 | 173 | | |
174 | | - | |
175 | 174 | | |
176 | 175 | | |
177 | 176 | | |
| |||
Lines changed: 0 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1118 | 1118 | | |
1119 | 1119 | | |
1120 | 1120 | | |
1121 | | - | |
1122 | | - | |
1123 | 1121 | | |
1124 | 1122 | | |
1125 | 1123 | | |
| |||
1139 | 1137 | | |
1140 | 1138 | | |
1141 | 1139 | | |
1142 | | - | |
1143 | | - | |
1144 | 1140 | | |
1145 | 1141 | | |
1146 | 1142 | | |
| |||
Lines changed: 6 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
1 | 2 | | |
2 | 3 | | |
3 | 4 | | |
| |||
114 | 115 | | |
115 | 116 | | |
116 | 117 | | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
117 | 123 | | |
118 | 124 | | |
119 | 125 | | |
| |||
Lines changed: 6 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
86 | 86 | | |
87 | 87 | | |
88 | 88 | | |
89 | | - | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
90 | 95 | | |
91 | 96 | | |
92 | 97 | | |
| |||
0 commit comments