Skip to content

Commit cbdff75

Browse files
SpencerWhitehead7Dagster Devtools
authored andcommitted
maint: remove dead test cli flag (#21606)
## Summary & Motivation https://dagsterlabs.slack.com/archives/C03AFEEDDNX/p1773246737232039 The flag is unused, adds complexity to the tests. Also added type annotations for pytest_addoption. ## Test Plan CI Internal-RevId: 70086e09a74b4fb3a52921d617168e2a8cdad671
1 parent 5164e97 commit cbdff75

6 files changed

Lines changed: 11 additions & 6 deletions

File tree

conftest.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
pass # Not all test suites have dagster installed
1414

1515

16-
def pytest_addoption(parser):
16+
def pytest_addoption(parser: pytest.Parser):
1717
parser.addoption(
1818
"--split", action="store", default=None, help="Split test selection (e.g., 0/3)"
1919
)

examples/docs_snippets/docs_snippets_tests/conftest.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ def pytest_configure():
3636
os.environ[DG_UPDATE_CHECK_ENABLED_ENV_VAR] = "0"
3737

3838

39-
def pytest_addoption(parser: pytest.Parser) -> None:
39+
def pytest_addoption(parser: pytest.Parser):
4040
parser.addoption(
4141
"--update-snippets",
4242
action="store_true",

integration_tests/test_suites/celery-k8s-test-suite/conftest.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ def dagster_docker_image():
3737

3838

3939
# See: https://stackoverflow.com/a/31526934/324449
40-
def pytest_addoption(parser):
40+
def pytest_addoption(parser: pytest.Parser):
4141
# We catch the ValueError to support cases where we are loading multiple test suites, e.g., in
4242
# the VSCode test explorer. When pytest tries to add an option twice, we get, e.g.
4343
#

integration_tests/test_suites/k8s-test-suite/conftest.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ def dagster_docker_image() -> str:
6262

6363

6464
# See: https://stackoverflow.com/a/31526934/324449
65-
def pytest_addoption(parser) -> None:
65+
def pytest_addoption(parser: pytest.Parser):
6666
# We catch the ValueError to support cases where we are loading multiple test suites, e.g., in
6767
# the VSCode test explorer. When pytest tries to add an option twice, we get, e.g.
6868
#

python_modules/libraries/dagster-airflow/conftest.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,10 @@
1+
import pytest
2+
13
pytest_plugins = ["dagster_test.fixtures"]
24

35

46
# See: https://stackoverflow.com/a/31526934/324449
5-
def pytest_addoption(parser):
7+
def pytest_addoption(parser: pytest.Parser):
68
# We catch the ValueError to support cases where we are loading multiple test suites, e.g., in
79
# the VSCode test explorer. When pytest tries to add an option twice, we get, e.g.
810
#

python_modules/libraries/dagster-celery/conftest.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,8 @@
1+
import pytest
2+
3+
14
# See: https://stackoverflow.com/a/31526934/324449
2-
def pytest_addoption(parser):
5+
def pytest_addoption(parser: pytest.Parser):
36
# We catch the ValueError to support cases where we are loading multiple test suites, e.g., in
47
# the VSCode test explorer. When pytest tries to add an option twice, we get, e.g.
58
#

0 commit comments

Comments
 (0)