Skip to content

Commit d742deb

Browse files
smackeseyDagster Devtools
authored andcommitted
fix(dagster-cloud-cli): use OSS-internal-compatible relative path to dagster-shared (#25430)
## Summary `dagster-oss/python_modules/libraries/dagster-cloud-cli/pyproject.toml` is the only dagster-oss pyproject whose `[tool.uv.sources]` references `dagster-shared` via the longer `../../../python_modules/libraries/dagster-shared` form. Every other pyproject uses the simpler `../dagster-shared`. Normalize this one to match. ```diff [tool.uv.sources] -dagster-shared = { path = "../../../python_modules/libraries/dagster-shared", editable = true } +dagster-shared = { path = "../dagster-shared", editable = true } ``` Both forms resolve to the same on-disk path in the OSS-standalone repo and in the internal repo's `dagster-oss/` mirror, so this is purely a normalization — but the shorter form is robust to one CI scenario where the longer form silently breaks. ## What the longer form breaks (and the shorter one fixes) The `elementl-code-locations / deploy-toys` GHA workflow stages the Docker build context with: ```bash cp -r dagster-oss/python_modules python_modules/toys/deps ``` Inside the container after `COPY . /opt/dagster/app`: - `dagster-cloud-cli` lands at `/opt/dagster/app/deps/libraries/dagster-cloud-cli/` - The old `../../../python_modules/libraries/dagster-shared` walks up to `/opt/dagster/app/` then descends into a `python_modules/` directory that no longer exists (the workflow renamed it to `deps/`). uv fails with: ``` error: Distribution not found at: file:///opt/dagster/app/python_modules/libraries/dagster-shared ``` - The new `../dagster-shared` only references the sibling name, so it resolves to `/opt/dagster/app/deps/libraries/dagster-shared` ✓ — same as in the OSS source tree. This break was latent on master: no PR has touched `python_modules/toys/**` (the path filter that gates `deploy-toys`) for ~a month, so the deploy job hadn't actually run. The `uv.lock` already encodes `editable = "../dagster-shared"`, so no relock is needed and the lockfile diff is empty. ## Test plan - [x] Reproduce the deploy-toys failure locally on master HEAD by extracting `master:dagster-oss/python_modules` into a fresh `deps/` build context and running the Dockerfile's `uv pip install` command → matches the CI error exactly. - [x] Apply this fix and re-run the same reproduction → 189 packages resolve and build successfully. - [x] `uv run --frozen python dagster-oss/scripts/update_lockfiles.py dagster-cloud-cli` → no lockfile changes (already consistent). - [ ] CI / next deploy-toys run. Internal-RevId: 7879b7c4419b9d517e89a4d85cbec9f3d7fb2fdf
1 parent ca84a62 commit d742deb

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

python_modules/libraries/dagster-cloud-cli/pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,4 +45,4 @@ test = [
4545
]
4646

4747
[tool.uv.sources]
48-
dagster-shared = { path = "../../../python_modules/libraries/dagster-shared", editable = true }
48+
dagster-shared = { path = "../dagster-shared", editable = true }

0 commit comments

Comments
 (0)