Revert "Use StaticFiles for directories in static routes (#29026)" (#29131)

Author: schrockn

python_modules/dagster-webserver/dagster_webserver/webserver.py

@@ -1,9 +1,8 @@
 import gzip
 import io
 import mimetypes
-import os
 import uuid
-from os import path
+from os import path, walk
 from typing import Generic, Optional, TypeVar
 
 import dagster._check as check
@@ -33,7 +32,6 @@
     StreamingResponse,
 )
 from starlette.routing import Mount, Route, WebSocketRoute
-from starlette.staticfiles import StaticFiles
 from starlette.types import Message
 
 from dagster_webserver.external_assets import (
@@ -260,24 +258,12 @@ def _static_file(path, file_path):
 
         routes = []
         base_dir = self.relative_path("webapp/build/")
-        with os.scandir(base_dir) as entries:
-            for entry in entries:
-                if entry.is_symlink():
-                    continue
-                relative_path = "/" + path.relpath(entry.path, base_dir).replace(path.sep, "/")
-                if entry.is_file():
-                    routes.append(_static_file(relative_path, entry.path))
-                elif entry.is_dir():
-                    routes.append(
-                        Mount(
-                            relative_path,
-                            StaticFiles(
-                                directory=entry.path,
-                                check_dir=False,
-                            ),
-                            name="root_static",
-                        )
-                    )
+        for subdir, _, files in walk(base_dir):
+            for file in files:
+                full_path = path.join(subdir, file)
+                # Replace path.sep to make sure our routes use forward slashes on windows
+                mount_path = "/" + full_path[len(base_dir) :].replace(path.sep, "/")
+                routes.append(_static_file(mount_path, full_path))
 
         # No build directory, this happens in a test environment. Don't fail loudly since we already have other tests that will fail loudly if
         # there is in fact no build

python_modules/dagster-webserver/dagster_webserver_tests/webserver/test_app.py

@@ -81,7 +81,7 @@ def test_static_resources(test_client: TestClient):
         assert response.status_code == 200, response.text
         assert response.headers["content-type"] != "text/html"
 
-    response = test_client.get("vendor/graphiql/graphiql.min.js")
+    response = test_client.get("/vendor/graphql-playground/middleware.js")
     assert response.status_code == 200, response.text
     assert response.headers["content-type"] != "application/js"