Skip to content

Commit fdfd0a5

Browse files
committed
fix-test
1 parent d6313c7 commit fdfd0a5

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

docs/docs/guides/labs/components/building-pipelines-with-components/adding-components.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ This will create a new directory inside your `components/` folder that contains
5050
The `component.yaml` is the primary configuration file for a component. It contains two top-level fields:
5151

5252
- `type`: The type of the component defined in this directory
53-
- `attributes`: A dictionary of attributes that are specific to this component type. The schema for these attributes is defined by the `get_schema` method on the component class.
53+
- `attributes`: A dictionary of attributes that are specific to this component type. The schema for these attributes is defined by attributes on the `Component` and totally customized by overriding `get_model_cls` method on the component class.
5454

5555
To see a sample `component.yaml` file for your specific component, you can run:
5656

python_modules/libraries/dagster-dg/dagster_dg_tests/cli_tests/test_utils_inspect_command.py

+4-2
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,7 @@
4343
Component schema:
4444
4545
{
46+
"additionalProperties": false,
4647
"properties": {
4748
"asset_key": {
4849
"title": "Asset Key",
@@ -57,7 +58,7 @@
5758
"asset_key",
5859
"filename"
5960
],
60-
"title": "SimplePipesScriptScaffoldParams",
61+
"title": "SimplePipesScriptComponentModel",
6162
"type": "object"
6263
}
6364
""").strip()
@@ -155,6 +156,7 @@ def test_utils_inspect_component_type_flag_fields_success():
155156
assert result.output.strip().endswith(
156157
textwrap.dedent("""
157158
{
159+
"additionalProperties": false,
158160
"properties": {
159161
"asset_key": {
160162
"title": "Asset Key",
@@ -169,7 +171,7 @@ def test_utils_inspect_component_type_flag_fields_success():
169171
"asset_key",
170172
"filename"
171173
],
172-
"title": "SimplePipesScriptScaffoldParams",
174+
"title": "SimplePipesScriptComponentModel",
173175
"type": "object"
174176
}
175177
""").strip()

0 commit comments

Comments
 (0)