chore(ruff): bump to 0.15.14 and enable PERF401 (#25026)

## Summary & Motivation

Bumps ruff `0.15.13 → 0.15.14` and enables `PERF401`
(manual-list-comprehension), which has been a long-standing
temporary-disable in `dagster-oss/config/ruff.toml`.

Ruff 0.15.14 ships an auto-fix for `PERF401` in **preview** mode. I ran
`ruff check --select PERF401 --preview --unsafe-fixes --fix . && ruff
format .`, which fixed all 241 violations across the repo (net **-119
lines**). The rule is now enabled in the default config (no preview
required at check time — preview was only needed to apply the bulk fix).
The temporary-disable comment for `PERF401` is removed; `PERF402` stays
in the ignore list (still no auto-fix even in preview).

## Scope

- `dagster-oss/config/ruff.toml`: `required-version` bump, `PERF401`
removed from temporary-disables.
- Ruff pin bumps in 3 other `pyproject.toml`s (`pyproject.toml`,
`python_modules/purina/pyproject.toml`,
`public/skills/dagster-skills-evals/pyproject.toml`,
`dagster-oss/python_modules/dagster/pyproject.toml`).
- `uv.lock` (internal) and `dagster-oss/python_modules/dagster/uv.lock`
relocked. The internal relock also pulled `ty` from `0.0.38 → 0.0.39` as
an incidental dependency update.
- ~170 `.py` files: mechanical ruff auto-fix output. Every change is one
of: a `for…append` loop collapsed into a list comprehension, or
`extend(generator)`.

## Side effects the auto-fix exposed

The PERF401 transformation removed `xxx = []` initializers and `for`
bodies, which surfaced 4 latent lint errors:

- **3 × `D202`** (no blank line after docstring): the auto-fix left a
blank line between a docstring and the next statement. Auto-fixed in a
second `ruff check --fix` pass.
- **1 × `F841` (`specs` unused)** in
`dagster-oss/python_modules/libraries/dagster-shared/dagster_shared_tests/test_record_jit.py`:
the test deliberately constructs `Spec(...)` instances inside a loop to
exercise `@record` JIT-collision behavior; `specs` itself was never
read. The PERF401 fix preserved runtime behavior (the comprehension
still constructs each `Spec`) but exposed the latent unused-variable
warning. Added `assert len(specs) == len(checks)` to make the variable
load-bearing while keeping the original test semantics.

## Verification

- `just ruff` — clean (check + format).
- `uvx ruff@0.15.14 check --select PERF401,PERF402 .` — only the 10
known `PERF402` violations remain (unchanged).

Internal-RevId: 04c6647013db97b4e51e40d56a42e7152a1a9cf2

Author: smackesey

.buildkite/buildkite-shared/lints.py

@@ -35,10 +35,9 @@ def test_tox_passenv(tox_config: configparser.ConfigParser) -> None:
         "PYTEST_PLUGINS",
     ]
 
-    missing_env = []
-    for env in PASSENV_ENV:
-        if env not in tox_config["testenv"]["passenv"].split("\n"):
-            missing_env.append(env)
+    missing_env = [
+        env for env in PASSENV_ENV if env not in tox_config["testenv"]["passenv"].split("\n")
+    ]
 
     assert not missing_env, f"tox.ini missing passenv {missing_env}"
 

.buildkite/dagster-buildkite/dagster_buildkite/steps/test_project.py

@@ -34,56 +34,54 @@ def build_test_project_steps() -> list[GroupStepConfiguration]:
     """This set of tasks builds and pushes Docker images, which are used by the dagster-airflow and
     the dagster-k8s tests.
     """
-    steps: list[GroupLeafStepConfiguration] = []
-
     # Build for all available versions because a dependent extension might need to run tests on any version.
     py_versions = AvailablePythonVersion.get_all()
 
-    for version in py_versions:
-        steps.append(
-            CommandStepBuilder(_test_project_step_key(version), [":docker:"])
-            # these run commands are coupled to the way the buildkite-build-test-project-image is built
-            # see python_modules/automation/automation/docker/images/buildkite-build-test-project-image
-            .run(
-                # credentials
-                "/scriptdir/aws.pex ecr get-login --no-include-email --region us-west-2 | sh",
-                f'export GOOGLE_APPLICATION_CREDENTIALS="{GCP_CREDS_LOCAL_FILE}"',
-                "/scriptdir/aws.pex s3 cp"
-                f" s3://$${{BUILDKITE_SECRETS_BUCKET}}/{GCP_CREDS_FILENAME}"
-                " $${GOOGLE_APPLICATION_CREDENTIALS}",
-                "export"
-                " BASE_IMAGE=$${AWS_ACCOUNT_ID}.dkr.ecr.us-west-2.amazonaws.com/test-project-base:py"
-                + version.value
-                + "-"
-                + TEST_PROJECT_BASE_IMAGE_VERSION,
-                # build and tag test image
-                "export"
-                " TEST_PROJECT_IMAGE=$${AWS_ACCOUNT_ID}.dkr.ecr.us-west-2.amazonaws.com/test-project:$${BUILDKITE_BUILD_ID}-"
-                + version.value,
-                "git config --global --add safe.directory /workdir",
-                f"./{oss_path('python_modules/dagster-test/dagster_test/test_project/build.sh')} "
-                + version.value
-                + " $${TEST_PROJECT_IMAGE}",
-                #
-                # push the built image
-                'echo -e "--- \033[32m:docker: Pushing Docker image\033[0m"',
-                "docker push $${TEST_PROJECT_IMAGE}",
-            )
-            .skip(skip_if_version_not_needed(version))
-            .on_python_image(
-                image=f"buildkite-build-test-project-image:py{AvailablePythonVersion.V3_11.value}-{BUILDKITE_BUILD_TEST_PROJECT_IMAGE_IMAGE_VERSION}",
-                env=[
-                    "AIRFLOW_HOME",
-                    "AWS_ACCOUNT_ID",
-                    "AWS_ACCESS_KEY_ID",
-                    "AWS_SECRET_ACCESS_KEY",
-                    "BUILDKITE_SECRETS_BUCKET",
-                ],
-            )
-            .with_ecr_login()
-            .with_docker()  # build.sh runs `docker build`; final step `docker push`
-            .build()
+    steps: list[GroupLeafStepConfiguration] = [
+        CommandStepBuilder(_test_project_step_key(version), [":docker:"])
+        # these run commands are coupled to the way the buildkite-build-test-project-image is built
+        # see python_modules/automation/automation/docker/images/buildkite-build-test-project-image
+        .run(
+            # credentials
+            "/scriptdir/aws.pex ecr get-login --no-include-email --region us-west-2 | sh",
+            f'export GOOGLE_APPLICATION_CREDENTIALS="{GCP_CREDS_LOCAL_FILE}"',
+            "/scriptdir/aws.pex s3 cp"
+            f" s3://$${{BUILDKITE_SECRETS_BUCKET}}/{GCP_CREDS_FILENAME}"
+            " $${GOOGLE_APPLICATION_CREDENTIALS}",
+            "export"
+            " BASE_IMAGE=$${AWS_ACCOUNT_ID}.dkr.ecr.us-west-2.amazonaws.com/test-project-base:py"
+            + version.value
+            + "-"
+            + TEST_PROJECT_BASE_IMAGE_VERSION,
+            # build and tag test image
+            "export"
+            " TEST_PROJECT_IMAGE=$${AWS_ACCOUNT_ID}.dkr.ecr.us-west-2.amazonaws.com/test-project:$${BUILDKITE_BUILD_ID}-"
+            + version.value,
+            "git config --global --add safe.directory /workdir",
+            f"./{oss_path('python_modules/dagster-test/dagster_test/test_project/build.sh')} "
+            + version.value
+            + " $${TEST_PROJECT_IMAGE}",
+            #
+            # push the built image
+            'echo -e "--- \033[32m:docker: Pushing Docker image\033[0m"',
+            "docker push $${TEST_PROJECT_IMAGE}",
+        )
+        .skip(skip_if_version_not_needed(version))
+        .on_python_image(
+            image=f"buildkite-build-test-project-image:py{AvailablePythonVersion.V3_11.value}-{BUILDKITE_BUILD_TEST_PROJECT_IMAGE_IMAGE_VERSION}",
+            env=[
+                "AIRFLOW_HOME",
+                "AWS_ACCOUNT_ID",
+                "AWS_ACCESS_KEY_ID",
+                "AWS_SECRET_ACCESS_KEY",
+                "BUILDKITE_SECRETS_BUCKET",
+            ],
         )
+        .with_ecr_login()
+        .with_docker()  # build.sh runs `docker build`; final step `docker push`
+        .build()
+        for version in py_versions
+    ]
     return [
         GroupStepBuilder(
             "test-project-image",

config/ruff.toml

@@ -26,7 +26,7 @@ target-version = "py310"
 line-length = 100
 
 # Fail if Ruff is not running this version.
-required-version = "0.15.13"
+required-version = "0.15.14"
 
 [lint]
 
@@ -85,9 +85,8 @@ ignore = [
   "D205", # (blank line after summary)
   "D417", # (missing arg in docstring)
 
-  # (assorted perf rules) We have a lot of violations, enable when autofix is available
-  "PERF401", # (manual-list-comprehension)
-  "PERF402", # (manual-list-copy)
+  # (manual-list-copy) No autofix available; enable once violations are fixed by hand.
+  "PERF402",
 
 ]
 

docs/scripts/rebuild-kinds-tags.py

@@ -135,15 +135,15 @@ def main() -> None:
     docs_file_new_contents.append("|-----|-------|")
 
     # Table content
-    for kind in output:
-        docs_file_new_contents.append(
-            KIND_LINE.format(
-                kind=kind,
-                kind_spacing=" " * (20 - len(kind)),
-                image=kind_docs_images.get(kind, ""),
-                image_spacing=" " * (100 - len(kind_docs_images.get(kind, ""))),
-            )
+    docs_file_new_contents.extend(
+        KIND_LINE.format(
+            kind=kind,
+            kind_spacing=" " * (20 - len(kind)),
+            image=kind_docs_images.get(kind, ""),
+            image_spacing=" " * (100 - len(kind_docs_images.get(kind, ""))),
         )
+        for kind in output
+    )
 
     KIND_TAGS_DOCS_PARTIAL.write_text("\n".join(docs_file_new_contents))
 

docs/sphinx/_ext/dagster-sphinx/dagster_sphinx/configurable.py

@@ -81,9 +81,11 @@ def config_field_to_lines(field, name=None) -> list[str]:
         if field.description:
             # trim / normalize whitespace. some of our config descriptions misuse triple-quote blocks
             # so this makes them look nicer
-            for ln in field.description.split("\n"):
-                # escape '*' characters because they get interpreted as emphasis markers in rst
-                lines.append(" " * 4 + textwrap.dedent(ln.replace("*", "\\*")))
+            # escape '*' characters because they get interpreted as emphasis markers in rst
+            lines.extend(
+                " " * 4 + textwrap.dedent(ln.replace("*", "\\*"))
+                for ln in field.description.split("\n")
+            )
             lines.append("")
 
         if field.default_provided:
@@ -96,8 +98,7 @@ def config_field_to_lines(field, name=None) -> list[str]:
                 lines.append("")
                 lines.append("        .. code-block:: javascript")
                 lines.append("")
-                for ln in ls:
-                    lines.append(" " * 12 + ln)
+                lines.extend(" " * 12 + ln for ln in ls)
             else:
                 lines.append("")
                 lines.append(f"    **Default Value:** {val!r}")

examples/docs_projects/project_ask_ai_dagster/src/project_ask_ai_dagster/defs/github.py

@@ -58,8 +58,7 @@ def _fetch_results(self, query_str: str, object_type: str) -> list[dict]:
             result = client.execute(query)
             search = result["search"]
             edges = search["edges"]
-            for node in edges:
-                results.append(node["node"])
+            results.extend(node["node"] for node in edges)
             log.info(f"Total results: {len(results)}")
             if not search["pageInfo"]["hasNextPage"]:
                 break
@@ -191,9 +190,11 @@ def convert_issues_to_documents(self, items: list[dict[str, Any]]) -> list[Docum
 
                 # Add comments if present
                 if "comments" in item and "nodes" in item["comments"]:
-                    for comment in item["comments"]["nodes"]:
-                        if comment and "body" in comment:
-                            content_parts.append(f"Comment: {comment['body']}")
+                    content_parts.extend(
+                        f"Comment: {comment['body']}"
+                        for comment in item["comments"]["nodes"]
+                        if comment and "body" in comment
+                    )
 
                 # Create document with properly formatted content
                 doc = Document(page_content="\n\n".join(content_parts), metadata=metadata)

examples/docs_projects/project_ask_ai_dagster/src/project_ask_ai_dagster/defs/scraper.py

@@ -38,10 +38,7 @@ def scrape_page(self, url: str) -> Document | None:
             main_content = soup.find("main") or soup.find("article") or soup.body
 
             if main_content:
-                content = []
-                for elem in main_content.stripped_strings:
-                    if elem.strip():
-                        content.append(elem.strip())
+                content = [elem.strip() for elem in main_content.stripped_strings if elem.strip()]
                 text_content = "\n".join(content)
             else:
                 text_content = "\n".join(s.strip() for s in soup.stripped_strings if s.strip())

examples/docs_projects/project_llm_fine_tune/src/project_llm_fine_tune/defs/assets.py

@@ -228,9 +228,10 @@ def training_file(
     enriched_graphic_novels,
 ) -> str:
     graphic_novels = enriched_graphic_novels.sample(n=TRAINING_FILE_NUM)
-    prompt_data = []
-    for record in [row for _, row in graphic_novels.iterrows()]:
-        prompt_data.append(create_prompt_record(record, CATEGORIES))
+    prompt_data = [
+        create_prompt_record(record, CATEGORIES)
+        for record in [row for _, row in graphic_novels.iterrows()]
+    ]
 
     file_name = "goodreads-training.jsonl"
     write_openai_file(file_name, prompt_data)
@@ -249,9 +250,10 @@ def validation_file(
     enriched_graphic_novels,
 ) -> str:
     graphic_novels = enriched_graphic_novels.sample(n=VALIDATION_FILE_NUM)
-    prompt_data = []
-    for record in [row for _, row in graphic_novels.iterrows()]:
-        prompt_data.append(create_prompt_record(record, CATEGORIES))
+    prompt_data = [
+        create_prompt_record(record, CATEGORIES)
+        for record in [row for _, row in graphic_novels.iterrows()]
+    ]
 
     file_name = "goodreads-validation.jsonl"
     write_openai_file(file_name, prompt_data)

examples/docs_projects/project_ml/src/project_ml/defs/resources.py

@@ -111,10 +111,11 @@ def list_models(self) -> list[str]:
                 return []
 
             # Get model files and their last modified times
-            model_objects = []
-            for obj in response["Contents"]:
-                if obj["Key"].endswith(".pth"):
-                    model_objects.append({"key": obj["Key"], "last_modified": obj["LastModified"]})
+            model_objects = [
+                {"key": obj["Key"], "last_modified": obj["LastModified"]}
+                for obj in response["Contents"]
+                if obj["Key"].endswith(".pth")
+            ]
 
             # Sort by modification time, newest first
             model_objects.sort(key=lambda x: x["last_modified"], reverse=True)

examples/docs_snippets/docs_snippets/guides/build/assets/data-assets/quality-testing/data-contracts/assets.py

@@ -90,18 +90,16 @@ def validate_shipments_data_contract(
 
     # Compare schemas
     mismatches = []
-    missing_columns = []
-    extra_columns = []
 
     # Check for missing columns in actual schema
-    for col_name in expected_schema:
-        if col_name not in actual_schema:
-            missing_columns.append(col_name)
+    missing_columns = [
+        col_name for col_name in expected_schema if col_name not in actual_schema
+    ]
 
     # Check for extra columns in actual schema
-    for col_name in actual_schema:
-        if col_name not in expected_schema:
-            extra_columns.append(col_name)
+    extra_columns = [
+        col_name for col_name in actual_schema if col_name not in expected_schema
+    ]
 
     # Check for type mismatches
     for col_name in expected_schema: