feat(dagster-client): support forced run termination #28339
+58
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Holger Bruch <[email protected]>
hbruch
force-pushed
the
feat/client-terminate-run-forced
branch
from
363bc40 to
dc7e57c
Compare
dpeng817
requested changes
Mar 13, 2025
| """Terminates a pipeline run. This method it is useful when you would like to stop a pipeline run | ||
| based on a external event. | ||
|
|
||
| Args: | ||
| run_id (str): The run id of the pipeline run to terminate | ||
| force (bool, optional): if false, run will be terminated using terminatePolicy SAFE_TERMINATE. |
There was a problem hiding this comment.
hm; not a huge fan of hiding terminatepolicy behind a flag like this. What if we down the road, add an additional terminatepolicy value? Seems like it would be hard to extend support here. How about instead we just take terminatePolicy directly?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
This PR adds the option to force terminate runs via
DagsterGraphQLClient.terminate_runandterminate_runsnow accept an additional boolean parameterforce. Iftrue,terminatePolicyis set toMARK_AS_CANCELED_IMMEDIATELY. Motivation is described in #28182Fixes #28338
Alternative implementation considered
I decided in favor of a boolean
forceparameter. Another option could be to instead chooseterminatePolicyas string param.How I Tested These Changes
python -m pytest python_modules/dagster-graphql/dagster_graphql_tests/client_testsChangelog
client.terminate_run(run_id)andclient.terminate_run(run_ids)now support an optional booleanforceparameter. Default isFalse.