Skip to content

Commit aff52ea

Browse files
authored
Merge pull request #16 from dagster-io/colton/integrations-audit-via-docs
[dagster-integrations,dagster-conventions] audit via documentation reference
2 parents 46c1a54 + 806f103 commit aff52ea

8 files changed

Lines changed: 189 additions & 119 deletions

File tree

CHANGELOG.md

Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,14 +8,42 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
88
## [Unreleased]
99

1010
### Added
11+
- **dagster-integrations**: Added comprehensive audit summary document (AUDIT_SUMMARY.md)
12+
- Documents all 82+ integration verifications
13+
- Lists critical fixes applied and remaining work
1114

1215
### Changed
16+
- **dagster-integrations**: Updated storage.md integration examples
17+
- Improved Postgres section with ConfigurableResource pattern and instance storage clarification
18+
- Updated Delta Lake to use correct `DeltaTableResource` API
19+
- Enhanced Redshift example with `RedshiftClientResource`
20+
- Improved DataHub example with correct `DatahubRESTEmitterResource`
21+
- Updated LakeFS to show custom resource pattern with lakefs-client SDK
1322

1423
### Deprecated
1524

1625
### Removed
26+
- **dagster-integrations**: Removed fabricated integrations from storage.md
27+
- Removed MongoDB section (dagster-mongo package doesn't exist)
28+
- Removed Atlan section (Dagster+ cloud CLI feature, not a Python library)
29+
- Removed Secoda section (no library integration exists)
1730

1831
### Fixed
32+
- **dagster-integrations**: Fixed critical PostgresResource hallucinations across multiple files
33+
- storage.md: Replaced fabricated dagster-postgres resource API with custom ConfigurableResource pattern
34+
- Fixed 5 support level misclassifications:
35+
- dagster-looker: Community-supported → Dagster-supported
36+
- dagster-sigma: Community-supported → Dagster-supported
37+
- dagster-polars: Dagster-supported → Community-supported
38+
- dagster-wandb: Dagster-supported → Community-supported
39+
- dagster-papertrail: Community-supported → Dagster-supported
40+
- **dagster-conventions**: Fixed PostgresResource hallucinations in resources.md
41+
- Updated factory pattern example with custom PostgresResource definition
42+
- **dagster-conventions**: Fixed PostgresResource hallucinations in testing.md
43+
- Updated test examples with custom ConfigurableResource implementations
44+
- **dagster-integrations**: Fixed other.md Polars integration
45+
- Removed non-existent `PolarsDataFrame` import
46+
- Corrected support level to Community-supported
1947

2048
### Security
2149

plugins/dagster-conventions/skills/dagster-conventions/references/resources.md

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -275,6 +275,26 @@ SNOWFLAKE_WAREHOUSE=PROD_WH
275275

276276
```python
277277
from typing import Literal
278+
from dagster import ConfigurableResource
279+
import psycopg2
280+
281+
# Define custom Postgres resource (dagster-postgres only provides instance storage)
282+
class PostgresResource(ConfigurableResource):
283+
"""Custom Postgres resource for asset data access."""
284+
host: str
285+
database: str
286+
user: str
287+
password: str
288+
port: int = 5432
289+
290+
def get_connection(self):
291+
return psycopg2.connect(
292+
host=self.host,
293+
port=self.port,
294+
user=self.user,
295+
password=self.password,
296+
database=self.database
297+
)
278298

279299
def create_database_resource(
280300
env: Literal["dev", "staging", "prod"]

plugins/dagster-conventions/skills/dagster-conventions/references/testing.md

Lines changed: 43 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -613,6 +613,27 @@ def test_materialization_with_mocked_resource():
613613
### Test with Real Services
614614

615615
```python
616+
from dagster import ConfigurableResource
617+
import psycopg2
618+
619+
# Define custom Postgres resource (dagster-postgres only provides instance storage)
620+
class PostgresResource(ConfigurableResource):
621+
"""Custom Postgres resource for asset data access."""
622+
host: str
623+
port: int = 5432
624+
database: str
625+
user: str
626+
password: str
627+
628+
def get_connection(self):
629+
return psycopg2.connect(
630+
host=self.host,
631+
port=self.port,
632+
user=self.user,
633+
password=self.password,
634+
database=self.database
635+
)
636+
616637
def test_database_integration():
617638
"""Integration test with actual database."""
618639
postgres_resource = PostgresResource(
@@ -622,9 +643,9 @@ def test_database_integration():
622643
user="test_user",
623644
password="test_pass",
624645
)
625-
646+
626647
result = state_population_database(postgres_resource)
627-
648+
628649
assert len(result) > 0
629650
```
630651

@@ -666,6 +687,26 @@ services:
666687
```python
667688
# tests/e2e/conftest.py
668689
import pytest
690+
from dagster import ConfigurableResource
691+
import psycopg2
692+
693+
# Define custom Postgres resource (dagster-postgres only provides instance storage)
694+
class PostgresResource(ConfigurableResource):
695+
"""Custom Postgres resource for asset data access."""
696+
host: str
697+
port: int = 5432
698+
database: str
699+
user: str
700+
password: str
701+
702+
def get_connection(self):
703+
return psycopg2.connect(
704+
host=self.host,
705+
port=self.port,
706+
user=self.user,
707+
password=self.password,
708+
database=self.database
709+
)
669710

670711
@pytest.fixture(scope="session")
671712
def postgres_resource():

plugins/dagster-integrations/skills/integrations-index/references/ai.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -143,7 +143,7 @@ def train_model(context):
143143
---
144144

145145
### Weights & Biases (W&B)
146-
**Package:** `dagster-wandb` | **Support:** Dagster-supported
146+
**Package:** `dagster-wandb` | **Support:** Community-supported
147147

148148
ML experiment tracking and visualization platform with advanced collaboration features.
149149

plugins/dagster-integrations/skills/integrations-index/references/bi.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ Business intelligence and visualization platforms for data exploration, dashboar
55
---
66

77
### Looker
8-
**Package:** `dagster-looker` | **Support:** Community-supported
8+
**Package:** `dagster-looker` | **Support:** Dagster-supported
99

1010
Google's business intelligence platform for creating interactive dashboards and SQL-based analytics.
1111

@@ -107,7 +107,7 @@ def refresh_powerbi_dataset(powerbi: PowerBIResource):
107107
---
108108

109109
### Sigma
110-
**Package:** `dagster-sigma` | **Support:** Community-supported
110+
**Package:** `dagster-sigma` | **Support:** Dagster-supported
111111

112112
Cloud-native analytics and BI platform with spreadsheet-like interface for data exploration.
113113

plugins/dagster-integrations/skills/integrations-index/references/monitoring.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ def track_metric(prometheus: PrometheusResource):
9191
---
9292

9393
### Papertrail
94-
**Package:** `dagster-papertrail` | **Support:** Community-supported
94+
**Package:** `dagster-papertrail` | **Support:** Dagster-supported
9595

9696
Send logs to Papertrail for centralized log management.
9797

plugins/dagster-integrations/skills/integrations-index/references/other.md

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ def events() -> EventDataFrame:
4646
---
4747

4848
### Polars
49-
**Package:** `dagster-polars` | **Support:** Dagster-supported
49+
**Package:** `dagster-polars` | **Support:** Community-supported
5050

5151
Fast DataFrame library with columnar storage and lazy evaluation, often 5-10x faster than pandas.
5252

@@ -58,7 +58,6 @@ Fast DataFrame library with columnar storage and lazy evaluation, often 5-10x fa
5858

5959
**Quick start:**
6060
```python
61-
from dagster_polars import PolarsDataFrame
6261
import polars as pl
6362

6463
@dg.asset

0 commit comments

Comments
 (0)