fix(ui): remove pro labels from sidebar

Author: yohamta0

ui/src/__tests__/menu.test.tsx

@@ -511,4 +511,27 @@ describe('sidebar menu', () => {
     expect(screen.getByRole('link', { name: /memory/i })).toBeVisible();
     expect(screen.getByRole('link', { name: /souls/i })).toBeVisible();
   });
+
+  it('does not append Pro labels to unavailable sidebar features', () => {
+    useHasFeatureMock.mockReturnValue(false);
+
+    renderMenu();
+
+    fireEvent.click(
+      screen.getByRole('button', { name: 'Toggle Monitor section' })
+    );
+    expect(screen.getByRole('link', { name: 'Audit Logs' })).toBeVisible();
+    expect(
+      screen.queryByRole('link', { name: 'Audit Logs (Pro)' })
+    ).not.toBeInTheDocument();
+
+    fireEvent.click(
+      screen.getByRole('button', { name: 'Toggle Administration section' })
+    );
+    fireEvent.click(screen.getByRole('button', { name: 'Access section' }));
+    expect(screen.getByRole('link', { name: 'Users' })).toBeVisible();
+    expect(
+      screen.queryByRole('link', { name: 'Users (Pro)' })
+    ).not.toBeInTheDocument();
+  });
 });

ui/src/menu.tsx

@@ -16,7 +16,6 @@ import {
   useIsAdmin,
 } from '@/contexts/AuthContext';
 import { useConfig } from '@/contexts/ConfigContext';
-import { useHasFeature } from '@/hooks/useLicense';
 import { cn } from '@/lib/utils';
 import { getResponsiveTitleClass } from '@/lib/text-utils';
 import { roleAtLeast } from '@/lib/workspaceAccess';
@@ -462,8 +461,6 @@ export const mainListItems = React.forwardRef<
   const config = useConfig();
   const isAdmin = useIsAdmin();
   const { user } = useAuth();
-  const hasRbac = useHasFeature('rbac');
-  const hasAudit = useHasFeature('audit');
   const canWrite =
     config.authMode !== 'builtin'
       ? config.permissions.writeDags
@@ -732,7 +729,7 @@ export const mainListItems = React.forwardRef<
               {canViewAuditLogs && (
                 <NavItem
                   to="/audit-logs"
-                  text={hasAudit ? 'Audit Logs' : 'Audit Logs (Pro)'}
+                  text="Audit Logs"
                   isOpen={isOpen}
                   onClick={onNavItemClick}
                   customColor={customColor}
@@ -879,7 +876,7 @@ export const mainListItems = React.forwardRef<
                 >
                   <NavItem
                     to="/users"
-                    text={hasRbac ? 'Users' : 'Users (Pro)'}
+                    text="Users"
                     isOpen={isOpen}
                     onClick={onNavItemClick}
                     customColor={customColor}