Add a URLSession implementation that provides transparent proxy support.#834
Draft
GaryHughes wants to merge 2 commits into
Draft
Add a URLSession implementation that provides transparent proxy support.#834GaryHughes wants to merge 2 commits into
GaryHughes wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds an engine implementation that is based on URLSession so we get transparent proxy support. I could not get that to work with the CFNetwork implementation and the NativeEngine does not work pre 10.15. This implementation works from 10.11 onwards.
It is not finished, has not had extensive testing, and I haven't tested at all on platforms other than macOS. I will continue to develop and test but I wanted to see if you're interested in the PR.
Thanks.