Skip to content

Commit c3f57eb

Browse files
committed
better http call
1 parent 13f1219 commit c3f57eb

1 file changed

Lines changed: 13 additions & 3 deletions

File tree

internal/templates/views/views_about.templ

Lines changed: 13 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ import (
1313
"golang.org/x/text/language"
1414
"net/http"
1515
"strings"
16+
"time"
1617
)
1718

1819
templ About(viewData common.ViewData) {
@@ -123,17 +124,26 @@ func getLatestRelease(owner, repo string) (string, string) {
123124
}
124125

125126
url := fmt.Sprintf("https://api.github.com/repos/%s/%s/releases/latest", owner, repo)
126-
link := fmt.Sprintf("https://github.com/%s/%s/releases/tag/latest", owner, repo)
127+
link := fmt.Sprintf("https://github.com/%s/%s/releases/latest", owner, repo)
127128

128-
resp, err := http.Get(url)
129+
client := &http.Client{
130+
Timeout: 10 * time.Second,
131+
}
132+
req, err := http.NewRequest("GET", url, nil)
133+
if err != nil {
134+
log.Error(err)
135+
return "Unknown", link
136+
}
137+
138+
resp, err := client.Do(req)
129139
if err != nil {
130140
log.Error(err)
131141
return "Unknown", link
132142
}
133143
defer resp.Body.Close()
134144

135145
if resp.StatusCode != 200 {
136-
log.Error(err)
146+
log.Errorf("GitHub API returned status code %d for %s", resp.StatusCode, url)
137147
return "Unknown", link
138148
}
139149

0 commit comments

Comments
 (0)