Merge my Japan NissanConnect implementation?

[developerfromjokela]

Hi.

I've forked your repo and implemented Japanese Domestic Market's NissanConnect app. Here's the repo: https://github.com/developerfromjokela/HomeAssistant-NissanConnect-JP.

I think maybe if we somehow merge it into the main repo so we don't have two identical applications :D

• DFJ

[dan-r]

I agree it's a good idea to get it merged. Leave it with me and I'll merge your changes.

Happy to make you a contributor for this repo too so you can maintain the Japan side

[dan-r]

@developerfromjokela I've made a start on the changes in the japan branch. Would you mind testing these?

https://github.com/dan-r/HomeAssistant-NissanConnect/tree/japan

[developerfromjokela]

@developerfromjokela I've made a start on the changes in the japan branch. Would you mind testing these?

https://github.com/dan-r/HomeAssistant-NissanConnect/tree/japan

Hi. I haven't had a chance to test yet. I'll reply back when I can.

[dan-r]

Hey @developerfromjokela - appreciate its been a while but if this is still something you're using it'd be great to get it merged in!

[developerfromjokela]

Hey @developerfromjokela - appreciate its been a while but if this is still something you're using it'd be great to get it merged in!

Hi. Honestly haven't been using anymore 😄 but should work I believe. If it's possible to sign in then should work. You can create an account at ev.nissanconnect.jp