Skip to content

Commit f695fa0

Browse files
committed
(fix) address review
1 parent 2c4cc3e commit f695fa0

File tree

1 file changed

+9
-6
lines changed

1 file changed

+9
-6
lines changed

src/app/components/BracketSection.tsx

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -46,8 +46,9 @@ const BracketSection: Component<BracketSectionProps> = (props) => {
4646
select: (data) => data.heats,
4747
}));
4848

49-
// Reset selection when divisionId changes
5049
createEffect(() => {
50+
// biome-ignore lint/correctness/noUnusedVariables: required to react to divisionId changes
51+
const noticeDivisionIdUpdate = props.divisionId
5152
setSelectedBracket(null);
5253
});
5354

@@ -167,19 +168,21 @@ const BracketSection: Component<BracketSectionProps> = (props) => {
167168
}
168169
};
169170

170-
const bracketFields = [
171-
{ name: "name", label: "Name", type: "text" as const, required: true },
171+
const generateBracketFields = [
172172
{
173173
name: "format",
174174
label: "Format",
175175
type: "select" as const,
176176
required: true,
177177
options: [
178178
{ value: "single_elimination", label: "Single Elimination" },
179-
{ value: "double_elimination", label: "Double Elimination" },
180-
{ value: "dingle", label: "Dingle" },
181179
],
182180
},
181+
];
182+
183+
const bracketFields = [
184+
{ name: "name", label: "Name", type: "text" as const, required: true },
185+
...generateBracketFields,
183186
{ name: "status", label: "Status", type: "text" as const, required: true },
184187
];
185188

@@ -410,7 +413,7 @@ const BracketSection: Component<BracketSectionProps> = (props) => {
410413
entity={null}
411414
onSave={handleGenerateBracket}
412415
onCancel={() => setShowGenerateBracketModal(false)}
413-
fields={bracketFields}
416+
fields={generateBracketFields}
414417
/>
415418

416419
<EntityFormModal

0 commit comments

Comments
 (0)