hidapitester not able to set maximum possible brightness

[Josh0711]

I've been experimenting with my Litra Beam and something is off with the max brightness. Setting the brightness to 250 / 0XFA with hidapi is still far from the maximum brightness the litra is capable of when setting the brightness in G-HUB.

[jslay88]

I think this is because of this line here.

The max brightness value is 400 (2 bytes Big Endian 0x01, 0x90), not 255. This code constrains it between 30 and 255, and hard codes the most significant bit to 0x00 here.

This should fix it.

public setBrightness(value: number): void {
  // Now uses a percentage 0-100 to reduce confusion
  const translatedValue = Math.round((value * (400 - 30)) / 100 + 30);

  const highByte = translatedValue >> 8; // Shifts the bits 8 places to the right, essentially dividing by 256 and keeping the quotient
  const lowByte = translatedValue & 0xFF; // AND operation with 0xFF (255) keeps only the lower 8 bits of the value

  write(
    this.#device,
    Buffer.from([0x11, 0xff, 0x04, 0x4f, highByte, lowByte])
  );
}