Skip to content

Conversation

@bendichter
Copy link
Member

No description provided.

@bendichter bendichter requested a review from kabilar April 28, 2025 18:00
@netlify
Copy link

netlify bot commented Apr 28, 2025

Deploy Preview for dandi-about ready!

Name Link
🔨 Latest commit cdd8926
🔍 Latest deploy log https://app.netlify.com/projects/dandi-about/deploys/6908e97f25a6e40008e30ee1
😎 Deploy Preview https://deploy-preview-112--dandi-about.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

- Introduced a comprehensive analysis of HDF5 and Zarr compression options for NWB files.
- Provided recommendations based on file size, read speed, and write speed.
- Included a detailed testing approach with results and visualizations.
- Added example code for testing various compression algorithms and settings.
@bendichter
Copy link
Member Author

@kabilar can you take a look at this please?

@bendichter
Copy link
Member Author

@kabilar ping


### Key Findings:

1. **Best Overall Performance: zstd level 4**
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might be misunderstanding something, but I don't see zstd level 4 in the plot. Is this referring to zstd (9,) or blosc zstd 4?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggestions:

  • Please add units to the axes.
  • The top left plot is missing a y-label.
  • Replace name in the legend with Compression algorithm + level.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps file size should be replaced with compression ratio so that it is easier to interpret?

Comment on lines 38 to 40
2. **Fastest Read Performance: blosc lz4**
- If optimizing primarily for read speed, blosc lz4 is 1.25x faster than zstd
- For blosc lz4, level 4 offers a good balance between size and speed
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might be misunderstanding, but it looks like blosc lz4hc and zstd (0,) has a faster read speed than blosc lz4.

image

Copy link
Member

@kabilar kabilar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bendichter. This is great. I have provided a few suggestions above.

@kabilar
Copy link
Member

kabilar commented Jun 23, 2025

Hi @bendichter, following up here. Thank you.

@kabilar kabilar self-requested a review October 29, 2025 19:13
@bendichter
Copy link
Member Author

Hi @kabilar how does this look? Ready to publish?

@kabilar
Copy link
Member

kabilar commented Nov 24, 2025

Hi Ben, thanks for the reminder. This is in my queue, but haven't had a chance to review it yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants