Cleanup unnecessary changes

Author: asmacdo

dandiapi/api/services/embargo/__init__.py

@@ -74,7 +74,6 @@ def unembargo_dandiset(ds: Dandiset, user: User):
     validate_version_metadata(version=v)
     logger.info('Version metadata validated')
 
-
     # Notify owners of completed unembargo
     send_dandiset_unembargoed_message(ds)
     logger.info('Dandiset owners notified.')
@@ -84,6 +83,7 @@ def unembargo_dandiset(ds: Dandiset, user: User):
     audit.unembargo_dandiset(dandiset=ds, user=user)
     transaction.on_commit(lambda: create_dandiset_draft_doi_task.delay(v.id))
 
+
 def remove_asset_blob_embargoed_tag(asset_blob: AssetBlob) -> None:
     """Remove the embargoed tag of an asset blob."""
     if asset_blob.embargoed:

dandiapi/api/services/publish/__init__.py

@@ -106,8 +106,6 @@ def _build_publishable_version_from_draft(draft_version: Version) -> Version:
     return publishable_version
 
 
-
-
 def _publish_dandiset(dandiset_id: int, user_id: int) -> None:
     """
     Publish a dandiset.

dandiapi/api/tests/test_asset_paths.py

@@ -298,7 +298,7 @@ def test_asset_path_search_asset_paths(draft_version_factory, asset_factory):
 
 
 @pytest.mark.django_db
-def test_asset_path_publish_version(draft_version_factory, asset_factory, user, mocker):
+def test_asset_path_publish_version(draft_version_factory, asset_factory, user):
     version: Version = draft_version_factory()
     asset = asset_factory(path='foo/bar.txt', status=Asset.Status.VALID)
     version.assets.add(asset)

dandiapi/api/tests/test_audit.py

@@ -118,7 +118,7 @@ def user_info(u):
 
 
 @pytest.mark.django_db
-def test_audit_update_metadata(api_client, draft_version, user, mocker):
+def test_audit_update_metadata(api_client, draft_version, user):
     # Create a Dandiset.
     dandiset = draft_version.dandiset
     add_dandiset_owner(dandiset, user)

dandiapi/api/tests/test_dandiset.py

@@ -363,7 +363,6 @@ def test_dandiset_rest_create(api_client, user):
     response = api_client.post(
         '/api/dandisets/', {'name': name, 'metadata': metadata}, format='json'
     )
-
     assert response.data == {
         'identifier': DANDISET_ID_RE,
         'created': TIMESTAMP_RE,
@@ -629,7 +628,7 @@ def test_dandiset_rest_create_with_contributor(api_client, admin_user):
 
 
 @pytest.mark.django_db
-def test_dandiset_rest_create_embargoed(api_client, user, mocker):
+def test_dandiset_rest_create_embargoed(api_client, user):
     user.first_name = 'John'
     user.last_name = 'Doe'
     user.save()
@@ -782,7 +781,6 @@ def test_dandiset_rest_delete(api_client, draft_version_factory, user, embargo_s
     else:
         assert response.status_code >= 400
         assert Dandiset.objects.count() == 1
-        # Verify that delete_or_hide_doi was not called
         mock_delete_doi.assert_not_called()
 
 

dandiapi/api/tests/test_version.py

@@ -719,15 +719,15 @@ def test_version_rest_update_not_an_owner(api_client, user, version):
 
 
 @pytest.mark.parametrize(
-    'access',
+    ('access'),
     [
         'some value',
         123,
         None,
         [],
         ['a', 'b'],
         ['a', 'b', {}],
-        [{'schemaKey': 'AccessRequirements', 'status': 'foobar'}]
+        [{'schemaKey': 'AccessRequirements', 'status': 'foobar'}],
     ],
 )
 @pytest.mark.django_db
@@ -741,6 +741,7 @@ def test_version_rest_update_access_values(api_client, user, draft_version, acce
         {'metadata': new_metadata, 'name': draft_version.name},
         format='json',
     )
+    assert resp.status_code == 200
     draft_version.refresh_from_db()
 
     access = draft_version.metadata['access']