modified timetamp for dandiset is not updated on asset add and not added to metadata

[satra]

two related things around modification time of dandiset:

1. @jwodder noticed that dandiset modified is not being updated when an asset is added: Idea: dandiset Version "wide" state sha256s dandisets#239 (comment)
2. the dandiset metadata does not update the dateModified key. (asset metadata does, but not dandiset metadata)

[jjnesbitt]

1. @jwodder noticed that dandiset modified is not being updated when an asset is added: Idea: dandiset Version "wide" state sha256s dandisets#239 (comment)

This isn't a bug as is, it was just never implemented that way. Currently, the containing version is updated, but not the dandiset. I could see an argument either way for propagating that to the dandiset itself, but my personal opinion is that only very high level operations (like publishing) should update the modified field on the dandiset itself.

2. the dandiset metadata does not update the dateModified key. (asset metadata does, but not dandiset metadata)

Indeed that seems like an oversight, and should be added here:

dandi-archive/dandiapi/api/models/version.py

Lines 243 to 254 in 7d1805f

	metadata = {
	**self.metadata,
	'manifestLocation': manifest_location(self),
	'name': self.name,
	'identifier': f'DANDI:{self.dandiset.identifier}',
	'version': self.version,
	'id': f'DANDI:{self.dandiset.identifier}/{self.version}',
	'repository': settings.DANDI_WEB_APP_URL,
	'url': f'{settings.DANDI_WEB_APP_URL}/dandiset/{self.dandiset.identifier}/{self.version}', # noqa
	'assetsSummary': summary,
	'dateCreated': self.dandiset.created.isoformat(),
	}

[satra]

only very high level operations (like publishing) should update the modified field on the dandiset itself.

i believe, any operation that changes metadata or assets on a dandiset should update the modified time. hence even, and especially, the dandiset metadata modifiedTime should reflect this notion.

i understand that your thought on the modified time comes perhaps from a database notion of whether that record was updated, not whether the linked constituents were.

i don't think we should have two different semantics of modified time. the question then becomes how to do this in a way that preserves this thought process. one option is to strip modified out of the record and only include metadata when requested (whether whole or in parts).