Skip to content

Add retries to sha256 checksum calculation task #1937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 30, 2024
Merged

Add retries to sha256 checksum calculation task #1937

merged 1 commit into from
Jul 30, 2024

Conversation

jjnesbitt
Copy link
Member

@jjnesbitt jjnesbitt commented May 9, 2024 •
edited
Loading

Closes #471

@yarikoptic yarikoptic mentioned this pull request May 10, 2024
Merged
@yarikoptic
Copy link
Member

I think this would close #471

@jjnesbitt jjnesbitt force-pushed the sha256-checksum-cron-job branch from 2b3930b to 725d5b0 Compare June 4, 2024 16:54
@jjnesbitt jjnesbitt force-pushed the sha256-checksum-cron-job branch 4 times, most recently from f8c7c91 to cbc1c99 Compare July 10, 2024 20:52
@jjnesbitt jjnesbitt marked this pull request as ready for review July 10, 2024 20:53
@jjnesbitt jjnesbitt requested a review from mvandenburgh July 10, 2024 20:53
@jjnesbitt jjnesbitt force-pushed the sha256-checksum-cron-job branch from cbc1c99 to 500914b Compare July 12, 2024 16:54
mvandenburgh
mvandenburgh requested changes Jul 23, 2024
View reviewed changes
@jjnesbitt jjnesbitt force-pushed the sha256-checksum-cron-job branch from 500914b to d4d5010 Compare July 30, 2024 00:49
@jjnesbitt jjnesbitt changed the title Add task for catching missing sha256 checksums Add retries to sha256 checksum calculation task Jul 30, 2024
@jjnesbitt jjnesbitt requested a review from mvandenburgh July 30, 2024 00:50
@jjnesbitt
Copy link
Member Author

jjnesbitt commented Jul 30, 2024 •
edited
Loading

I've reworked this PR to instead simply add retries to the sha256 checksum calculation task. This largely overlaps with my original implementation functionally, and will be easier to incrementally determine exactly why this is happening (a cron job would simply mask and/or extend the problem indefinitely).

As a follow up PR, I'd like to investigate if adding a sha256_status field would be helpful in determining at exactly what step the checksum calculation workflow breaks down, if any are still missing,

@jjnesbitt jjnesbitt added patch Increment the patch version when merged release Create a release when this pr is merged labels Jul 30, 2024
@jjnesbitt jjnesbitt merged commit 095afba into master Jul 30, 2024
11 checks passed
@jjnesbitt jjnesbitt deleted the sha256-checksum-cron-job branch July 30, 2024 14:23
@dandibot
Copy link
Member

🚀 PR was released in v0.3.92 🚀

@dandibot dandibot added the released This issue/pull request has been released. label Jul 30, 2024
@jjnesbitt jjnesbitt mentioned this pull request Jul 30, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yarikoptic yarikoptic yarikoptic left review comments

@mvandenburgh mvandenburgh mvandenburgh approved these changes

Assignees
No one assigned
Labels
patch Increment the patch version when merged release Create a release when this pr is merged released This issue/pull request has been released.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Monitor for AssetBlobs with undefined sha256
4 participants
@jjnesbitt @yarikoptic @dandibot @mvandenburgh