-
Notifications
You must be signed in to change notification settings - Fork 33
Support all known instances in short URL format #1750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
|
I vaguely recall we might have a listing of supported regexes dumped/hardcoded somewhere in docs. Please check and adjust if needed |
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## master #1750 +/- ##
===========================================
- Coverage 75.05% 52.71% -22.34%
===========================================
Files 84 84
Lines 11873 11847 -26
===========================================
- Hits 8911 6245 -2666
- Misses 2962 5602 +2640
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: yarikoptic <[email protected]>
- Changed regex from generic `[-\w._]+` to pattern composed from known instance names - Prevents false matches like `http:000001` or other invalid patterns - Pattern is built dynamically: dandi|dandi-staging|dandi-sandbox|...|ember-sandbox - All existing tests pass, invalid patterns now correctly rejected Co-authored-by: yarikoptic <[email protected]>
83173b1 to
3f49100
Compare
|
@copilot I submitted for rebase, when CI finishes up - please review failures and whether relate to the changes - and where they do - fix them. |
…URL format Co-authored-by: yarikoptic <[email protected]>
Found and updated
CI is still pending for this branch after the rebase. I ran the related tests locally ( Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
dandi/dandiarchive.pyto dynamically build the instance name pattern fromknown_instancesDANDI:<dandiset id>[/<version>]to<INSTANCE>:<dandiset id>[/<version>]docs/source/ref/urls.rstto reflect all known instances supportOriginal prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.