Make dandi-archive instance used by tests vendorizable #1756
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1756 +/- ##
==========================================
- Coverage 75.06% 75.05% -0.01%
==========================================
Files 84 84
Lines 11873 11873
==========================================
- Hits 8912 8911 -1
- Misses 2961 2962 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
candleindark
force-pushed
the
pass-vendor-info-to-tests
branch
3 times, most recently
from
b318e11 to
bad6700
Compare
There was a problem hiding this comment.
Pull request overview
This PR enables vendorization of the dandi-archive instance used in tests by making three instance-specific configuration values customizable through environment variables. This addresses issue #350 in dandi/dandi-schema by allowing tests to run against different DANDI instances with custom identifiers.
- Replaces hardcoded instance configuration values with environment variables that have backward-compatible defaults
- Uses bash parameter expansion syntax (
${VAR:-default}) to maintain existing behavior when environment variables are not set - Enables testing of vendorized DANDI instances by allowing customization of instance name, identifier, and DOI prefix
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
|
@candleindark I've opened a new pull request, #1757, to work on those changes. Once the pull request is ready, I'll request review from you. |
candleindark
force-pushed
the
pass-vendor-info-to-tests
branch
from
bad6700 to
5834722
Compare
Co-authored-by: candleindark <[email protected]>
Co-authored-by: candleindark <[email protected]>
docs: Document vendorizable test environment variables
|
Notes: The following remaining failure has nothing to do with changes in the PR but #1758. 
|
This PR makes the dandi-archive instance used by the tests vendorizable. It is a part of a solution to address dandi/dandi-schema#350. It gives a foundation for the solution at dandi/dandi-schema#355.