Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Nov 26, 2025

  • Document new environment variables in DEVELOPMENT.md
    • Add DANDI_TESTS_INSTANCE_NAME to "Environment variables" section
    • Add DANDI_TESTS_INSTANCE_IDENTIFIER to "Environment variables" section
    • Add DANDI_TESTS_DOI_PREFIX to "Environment variables" section
  • Updated env var names to match changes in Make dandi-archive instance used by tests vendorizable #1756 (DANDI_TEST_* → DANDI_TESTS_*)
  • Updated documentation wording per review feedback
  • Run code review
  • Run security scan (codeql_checker)

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI changed the title [WIP] Work in progress to address feedback on vendorizable instance docs: Document vendorizable test environment variables Nov 26, 2025
Copilot AI requested a review from candleindark November 26, 2025 01:04
Copilot finished work on behalf of candleindark November 26, 2025 01:04
@candleindark candleindark force-pushed the pass-vendor-info-to-tests branch from bad6700 to 5834722 Compare November 26, 2025 01:24
@candleindark
Copy link
Member

@copilot I have changed the env variable names in #1756. Can you update this PR accordingly?

Copy link
Contributor Author

Copilot AI commented Nov 26, 2025

@copilot I have changed the env variable names in #1756. Can you update this PR accordingly?

Updated the environment variable names to match #1756: DANDI_TEST_*DANDI_TESTS_* in commit d0a0141.

Copilot finished work on behalf of candleindark November 26, 2025 01:33
@codecov
Copy link

codecov bot commented Nov 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.05%. Comparing base (5834722) to head (56c7bfa).
⚠️ Report is 3 commits behind head on pass-vendor-info-to-tests.

Additional details and impacted files
@@                    Coverage Diff                     @@
##           pass-vendor-info-to-tests    #1757   +/-   ##
==========================================================
  Coverage                      75.05%   75.05%           
==========================================================
  Files                             84       84           
  Lines                          11873    11873           
==========================================================
  Hits                            8911     8911           
  Misses                          2962     2962           
Flag Coverage Δ
unittests 75.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot AI requested a review from candleindark November 26, 2025 01:52
Copilot finished work on behalf of candleindark November 26, 2025 01:52
@candleindark candleindark marked this pull request as ready for review November 26, 2025 01:56
@candleindark candleindark merged commit c49b51b into pass-vendor-info-to-tests Nov 26, 2025
33 of 37 checks passed
@candleindark candleindark deleted the copilot/sub-pr-1756 branch November 26, 2025 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants