Skip to content

Commit 1a3df66

Browse files
committed
Release 10.3.1
1 parent 779938f commit 1a3df66

File tree

3 files changed

+49
-14
lines changed

3 files changed

+49
-14
lines changed

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "danger",
3-
"version": "10.3.0",
3+
"version": "10.3.1",
44
"description": "Unit tests for Team Culture",
55
"main": "distribution/danger.js",
66
"typings": "distribution/danger.d.ts",

source/danger-incoming-process-schema.json

+25-4
Original file line numberDiff line numberDiff line change
@@ -1576,18 +1576,22 @@
15761576
"type": "object"
15771577
},
15781578
"GitLabDSL": {
1579+
"description": "The GitLab metadata for your MR",
15791580
"properties": {
15801581
"commits": {
1582+
"description": "All of the individual commits in the merge request",
15811583
"items": {
15821584
"$ref": "#/definitions/GitLabMRCommit"
15831585
},
15841586
"type": "array"
15851587
},
15861588
"metadata": {
1587-
"$ref": "#/definitions/RepoMetaData"
1589+
"$ref": "#/definitions/RepoMetaData",
1590+
"description": "Info about the repo"
15881591
},
15891592
"mr": {
1590-
"$ref": "#/definitions/GitLabMR"
1593+
"$ref": "#/definitions/GitLabMR",
1594+
"description": "Info about the merge request"
15911595
},
15921596
"utils": {
15931597
"type": "object"
@@ -1596,6 +1600,7 @@
15961600
"type": "object"
15971601
},
15981602
"GitLabMR": {
1603+
"description": "TODO: These need more comments from someone who uses GitLab, see GitLabDSL.ts in the danger-js repo",
15991604
"properties": {
16001605
"allow_collaboration": {
16011606
"type": "boolean"
@@ -1607,10 +1612,12 @@
16071612
"type": "null"
16081613
},
16091614
"assignee": {
1610-
"$ref": "#/definitions/GitLabUser"
1615+
"$ref": "#/definitions/GitLabUser",
1616+
"description": "Who was assigned as the person to review"
16111617
},
16121618
"author": {
1613-
"$ref": "#/definitions/GitLabUser"
1619+
"$ref": "#/definitions/GitLabUser",
1620+
"description": "Who made it"
16141621
},
16151622
"changes_count": {
16161623
"type": "string"
@@ -1632,9 +1639,11 @@
16321639
]
16331640
},
16341641
"created_at": {
1642+
"description": "When was the MR made",
16351643
"type": "string"
16361644
},
16371645
"description": {
1646+
"description": "The body text describing the MR",
16381647
"type": "string"
16391648
},
16401649
"diff_refs": {
@@ -1658,6 +1667,7 @@
16581667
"type": "number"
16591668
},
16601669
"downvotes": {
1670+
"description": "How many folks have given it an downvote",
16611671
"type": "number"
16621672
},
16631673
"first_deployed_to_production_at": {
@@ -1670,9 +1680,11 @@
16701680
"type": "boolean"
16711681
},
16721682
"id": {
1683+
"description": "The MR's id",
16731684
"type": "number"
16741685
},
16751686
"iid": {
1687+
"description": "The unique ID for this MR",
16761688
"type": "number"
16771689
},
16781690
"labels": {
@@ -1782,6 +1794,7 @@
17821794
"type": "object"
17831795
},
17841796
"project_id": {
1797+
"description": "The project ID for this MR",
17851798
"type": "number"
17861799
},
17871800
"rebase_in_progress": {
@@ -1794,6 +1807,7 @@
17941807
"type": "boolean"
17951808
},
17961809
"source_branch": {
1810+
"description": "What branch is this MR come from",
17971811
"type": "string"
17981812
},
17991813
"source_project_id": {
@@ -1803,6 +1817,7 @@
18031817
"type": "boolean"
18041818
},
18051819
"state": {
1820+
"description": "The MR's current availability",
18061821
"enum": [
18071822
"closed",
18081823
"locked",
@@ -1815,6 +1830,7 @@
18151830
"type": "boolean"
18161831
},
18171832
"target_branch": {
1833+
"description": "What branch is this MR being merged into",
18181834
"type": "string"
18191835
},
18201836
"target_project_id": {
@@ -1844,17 +1860,22 @@
18441860
"type": "object"
18451861
},
18461862
"title": {
1863+
"description": "The given name of the MR",
18471864
"type": "string"
18481865
},
18491866
"updated_at": {
1867+
"description": "When was the MR updated",
18501868
"type": "string"
18511869
},
18521870
"upvotes": {
1871+
"description": "How many folks have given it an upvote",
18531872
"type": "number"
18541873
},
18551874
"user": {
1875+
"description": "Access rights for the user who created the MR",
18561876
"properties": {
18571877
"can_merge": {
1878+
"description": "Does the author have access to merge?",
18581879
"type": "boolean"
18591880
}
18601881
},

source/danger.d.ts

+23-9
Original file line numberDiff line numberDiff line change
@@ -1427,12 +1427,16 @@ interface GitHubReviewers {
14271427

14281428
// getPlatformReviewDSLRepresentation
14291429
interface GitLabJSONDSL {
1430+
/** Info about the repo */
14301431
metadata: RepoMetaData
1432+
/** Info about the merge request */
14311433
mr: GitLabMR
1434+
/** All of the individual commits in the merge request */
14321435
commits: GitLabMRCommit[]
14331436
}
14341437

14351438
// danger.gitlab
1439+
/** The GitLab metadata for your MR */
14361440
interface GitLabDSL extends GitLabJSONDSL {
14371441
utils: {
14381442
fileContents(path: string, repoSlug?: string, ref?: string): Promise<string>
@@ -1477,40 +1481,49 @@ interface GitLabUserProfile extends GitLabUser {
14771481
}
14781482

14791483
interface GitLabMRBase {
1480-
/** */
1484+
/** The MR's id */
14811485
id: number
14821486

1483-
/** */
1487+
/** The unique ID for this MR */
14841488
iid: number
14851489

1486-
/** */
1490+
/** The project ID for this MR */
14871491
project_id: number
14881492

1489-
/** */
1493+
/** The given name of the MR */
14901494
title: string
14911495

1492-
/** */
1496+
/** The body text describing the MR */
14931497
description: string
14941498

1495-
/** */
1499+
/** The MR's current availability */
14961500
state: "closed" | "open" | "locked" | "merged"
14971501

1498-
/** */
1502+
/** When was the MR made */
14991503
created_at: string
15001504

1501-
/** */
1505+
/** When was the MR updated */
15021506
updated_at: string
15031507

1508+
/** What branch is this MR being merged into */
15041509
target_branch: string
1510+
/** What branch is this MR come from */
15051511
source_branch: string
1512+
1513+
/** How many folks have given it an upvote */
15061514
upvotes: number
1515+
/** How many folks have given it an downvote */
15071516
downvotes: number
15081517

1518+
/** Who made it */
15091519
author: GitLabUser
1520+
/** Access rights for the user who created the MR */
15101521
user: {
1522+
/** Does the author have access to merge? */
15111523
can_merge: boolean
15121524
}
1513-
assignee: GitLabUser
1525+
/** Who was assigned as the person to review */
1526+
assignee?: GitLabUser
15141527
source_project_id: number
15151528
target_project_id: number
15161529
labels: string[]
@@ -1548,6 +1561,7 @@ interface GitLabMRBase {
15481561
}
15491562
}
15501563

1564+
/** TODO: These need more comments from someone who uses GitLab, see GitLabDSL.ts in the danger-js repo */
15511565
interface GitLabMR extends GitLabMRBase {
15521566
squash: boolean
15531567
subscribed: boolean

0 commit comments

Comments
 (0)