Merge pull request #970 from HelloCore/fix/generated-bin

Fix generated bin doesn't work

Author: orta

CHANGELOG.md

@@ -15,6 +15,7 @@ x
 
 <!-- Your comment below this -->
 
+- Fix generated binary - [@hellocore]
   <!-- Your comment above this -->
 
 # 9.2.9

package.json

@@ -122,7 +122,7 @@
     "lint-staged": "^7.3.0",
     "madge": "^3.2.0",
     "nock": "^10.0.6",
-    "pkg": "^4.3.4",
+    "pkg": "^4.4.2",
     "prettier": "^1.14.2",
     "release-it": "^7.6.1",
     "shx": "^0.3.2",

source/ambient.d.ts

@@ -45,3 +45,13 @@ declare module "parse-git-config"
 declare module "parse-github-url"
 // Basically does one thing
 declare module "override-require"
+
+declare namespace NodeJS {
+  interface Process {
+    // https://github.com/zeit/pkg#snapshot-filesystem
+    pkg?: {
+      entrypoint: string
+      defaultEntrypoint: string
+    }
+  }
+}

source/commands/utils/_tests/dangerRunToRunnerCLI.test.ts

@@ -48,3 +48,37 @@ it("`danger pr --dangerfile 'myDanger file.ts'`", () => {
     "myDanger file.ts",
   ])
 })
+
+describe("it can handle the command when running from pkg", () => {
+  beforeAll(() => {
+    process.pkg = {
+      defaultEntrypoint: "Hello",
+      entrypoint: "World",
+    }
+  })
+
+  afterAll(() => {
+    process.pkg = undefined
+  })
+
+  it("`./brew-distribution/danger /snapshot/danger-js/distribution/commands/danger-pr.js --dangerfile myDangerfile.ts`", () => {
+    /**
+     * The example of argv
+     * [ '/Users/core/Documents/project/danger-js/brew-distribution/danger',
+     *    '/snapshot/danger-js/distribution/commands/danger-pr.js',
+     *    'https://bitbucket.org/foo/bar/pull-requests/381' ]
+     */
+    expect(
+      dangerRunToRunnerCLI([
+        "./brew-distribution/danger",
+        "/snapshot/danger-js/distribution/commands/danger-pr.js",
+        "--dangerfile",
+        "myDangerfile.ts",
+      ])
+    ).toEqual(
+      "./brew-distribution/danger /snapshot/danger-js/distribution/commands/danger-runner.js --dangerfile myDangerfile.ts".split(
+        " "
+      )
+    )
+  })
+})

source/commands/utils/dangerRunToRunnerCLI.ts

@@ -9,7 +9,7 @@ const dangerRunToRunnerCLI = (argv: string[]) => {
 
   if (argv.length === 1) {
     return ["danger", "runner"]
-  } else if (argv[0].includes("node")) {
+  } else if (argv[0].includes("node") || process.pkg != null) {
     // convert
     let newJSFile = argv[1]
     usesProcessSeparationCommands.forEach(name => {