Skip to content

Needs meaningful logging when hitting MR comment character limit #1178

Open
@krismanceaux

Description

@krismanceaux

I'm using Danger to post certain CI-generated report findings onto a Merge Request as a comment. If the comment exceeds GitLab's 1,000,000 characters limit, the resulting log output is:

$ npx danger ci --verbose --dangerfile /app/danger/dangerfile.js
Found only messages, passing those to review.
Error:  undefined

To Reproduce:

import { message } from "danger"
const s = "some string with more than 1,000,000 characters...";
message(s);

It's understood that this is a GitLab constraint, not a Danger JS constraint, but it would be nice for the error logging to be more meaningful here.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions