Skip to content

[BUG] Request failed [403]: https://api.github.com/user #1368

Open
@jcook-uptycs

Description

Describe the bug

Danger sends errors to the output for failed https://api.github.com/user connections.

While this does not cause danger to error, it does cause anyone who looks at the output to think danger failed because of a permissions issue, and ignores everything else.

We use the auto created token in GitHub workflows for Danger as it provides the access we need and doesn't have too much access.

To Reproduce
Steps to reproduce the behavior:

  1. Use the CI created GITHUB_TOKEN with danger.

Expected behavior

How can we make this more clear that this is NOT causing any issues. Not sure if it shouldn't show, or someway to display differently that doesn't make the user feel danger failed due to the 403 error.

Screenshots
If applicable, add screenshots to help explain your problem.

Request failed [403]: https://api.github.com/user
Response: {
  "message": "Resource not accessible by integration",
  "documentation_url": "https://docs.github.com/rest/reference/users#get-the-authenticated-user"
}
Request failed [403]: https://api.github.com/user
Response: {
  "message": "Resource not accessible by integration",
  "documentation_url": "https://docs.github.com/rest/reference/users#get-the-authenticated-user"
}

Your Environment

software version
danger.js 11.2.4
node v19.4.0
npm 9.2.0
Operating System Ubuntu

Additional context
Add any other context about the problem here.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions