Skip to content

[BUG] message does not attach to a file and line provided, and instead all comments are in the "main comment" section #1419

Open
@kadoshms

Description

Describe the bug

Seems like using the message API with a file and line doesn't always add the message as a comment on the file.
I would expect that for instance passing a foo.ts with line 6, would add the comment as follows:
image

Instead, the message is created under the "main comment" only - with the following format:
image

{FILE_PATH}:L{LINE_NUMBER} - message

To Reproduce
Steps to reproduce the behavior:

  1. Create a danger rule with message on a file and line
  2. Create an MR on GitLab Self-Hosted

Expected behavior
If provided, message should be inline to the file and line as a comment.

Screenshots
See above

Your Environment
GitLab Self-Hosted
D

software version
danger.js 11.3.1
node 16.20.1

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions