Merge pull request #625 from nakp/master

f-meloni · web-flow · commit 8f0bf9de181a · 2024-10-14T10:38:16.000+02:00
Remove deprecated --path param for swiftlint
diff --git a/Sources/Danger/Plugins/SwiftLint/SwiftLint.swift b/Sources/Danger/Plugins/SwiftLint/SwiftLint.swift
@@ -185,7 +185,7 @@ extension SwiftLint {
         var arguments = arguments
 
         if let directory = directory {
-            arguments.append("--path \"\(directory)\"")
+            arguments.append(directory)
         }
 
         return swiftlintViolations(swiftlintPath: swiftlintPath,
diff --git a/Tests/DangerTests/SwiftLint/DangerSwiftLintTests.swift b/Tests/DangerTests/SwiftLint/DangerSwiftLintTests.swift
@@ -268,7 +268,7 @@ final class DangerSwiftLintTests: XCTestCase {
         XCTAssertNotNil(swiftlintCommand)
         XCTAssertEqual(swiftlintCommand!.environmentVariables.count, 0)
         XCTAssertFalse(swiftlintCommand!.environmentVariables.values.contains { $0.contains("Tests/SomeFile.swift") })
-        XCTAssertTrue(swiftlintCommand!.arguments.contains("--path \"Tests\""))
+        XCTAssertEqual(swiftlintCommand!.arguments.last, directory)
     }
 
     func testFiltersOnSwiftFiles() {

Original file line number	Diff line number	Diff line change
`@@ -185,7 +185,7 @@ extension SwiftLint {`
`185`	`185`	`var arguments = arguments`
`186`	`186`
`187`	`187`	`if let directory = directory {`
`188`		`- arguments.append("--path \"\(directory)\"")`
	`188`	`+ arguments.append(directory)`
`189`	`189`	`}`
`190`	`190`
`191`	`191`	`return swiftlintViolations(swiftlintPath: swiftlintPath,`
Original file line number	Diff line number	Diff line change
`@@ -268,7 +268,7 @@ final class DangerSwiftLintTests: XCTestCase {`
`268`	`268`	`XCTAssertNotNil(swiftlintCommand)`
`269`	`269`	`XCTAssertEqual(swiftlintCommand!.environmentVariables.count, 0)`
`270`	`270`	`XCTAssertFalse(swiftlintCommand!.environmentVariables.values.contains { $0.contains("Tests/SomeFile.swift") })`
`271`		`- XCTAssertTrue(swiftlintCommand!.arguments.contains("--path \"Tests\""))`
	`271`	`+ XCTAssertEqual(swiftlintCommand!.arguments.last, directory)`
`272`	`272`	`}`
`273`	`273`
`274`	`274`	`func testFiltersOnSwiftFiles() {`